Rename variables from single letter to better naming

[patrickvonplaten]

Pretty much all code in https://github.com/huggingface/diffusers/blob/main/src/diffusers/models/resnet.py still corresponds to the copy-pasted version from the beginning.

While weight names shouldn't be renamed, we should rename all single letter variables to more explicit variable naming. E.g. h -> hidden_states.

Single letter variables are hard to deal with as search and replace doesn't work on them and are hard to read

[patrickvonplaten]

Also maybe @anton-l if you'd like

[patrickvonplaten]

That would be great @antival3nt 😍

[rashmimarganiatgithub]

@patrickvonplaten , please assign to me.

[patrickvonplaten]

Feel free to take it @rashmimarganiatgithub - all yours! Generally as soon as someone opens a PR for an issue, we try to work together on this PR

[daspartho]

Hi @patrickvonplaten
I'd be happy to work on any other variable names that need to be renamed.

[patil-suraj]

Hey @daspartho ! Awesome, there are some single letter variables in attention.py file, feel free to work on those if you want. I'm listing the places that needs change below.

diffusers/src/diffusers/models/attention.py

Line 140 in b2b3b1a

def forward(self, x, context=None):

diffusers/src/diffusers/models/attention.py

Line 195 in b2b3b1a

def forward(self, x, context=None):

diffusers/src/diffusers/models/attention.py

Line 313 in b2b3b1a

def forward(self, x):

diffusers/src/diffusers/models/attention.py

Line 331 in b2b3b1a

def forward(self, x):

[daspartho]

Hi @patil-suraj
Thank you for pointing out the necessary changes; I'll work on it.
I'm just not sure what the exact variable name for the single-letter variables should be. Can you please help me?
Thanks :)

[rashmimarganiatgithub]

@daspartho ,q, k, v can be replaced with query,key,value. b, c, h, w can be replaced with batch,channel,height,weight .

[daspartho]

Thank you for clarifying, @rashmimarganiatgithub. I'll start a PR soon.