Skip to content

Fix ema decay #1868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 30, 2022
Merged

Fix ema decay #1868

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
57c19e3
Fix ema decay and clarify nomenclature.
pcuenca Dec 30, 2022
65a0fd5
Rename var.
pcuenca Dec 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 5 additions & 10 deletions examples/text_to_image/train_text_to_image.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,24 +278,19 @@ def __init__(self, parameters: Iterable[torch.nn.Parameter], decay=0.9999):
self.decay = decay
self.optimization_step = 0

def get_decay(self, optimization_step):
"""
Compute the decay factor for the exponential moving average.
"""
value = (1 + optimization_step) / (10 + optimization_step)
return 1 - min(self.decay, value)

@torch.no_grad()
def step(self, parameters):
parameters = list(parameters)

self.optimization_step += 1
self.decay = self.get_decay(self.optimization_step)

# Compute the decay factor for the exponential moving average.
value = (1 + self.optimization_step) / (10 + self.optimization_step)
one_minus_decay = 1 - min(self.decay, value)

for s_param, param in zip(self.shadow_params, parameters):
if param.requires_grad:
tmp = self.decay * (s_param - param)
s_param.sub_(tmp)
s_param.sub_(one_minus_decay * (s_param - param))
else:
s_param.copy_(param)

Expand Down