Fix ema decay #1868
Merged
Fix ema decay #1868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
patil-suraj
approved these changes
Dec 30, 2022
Contributor
patil-suraj
left a comment
patil-suraj
left a comment
There was a problem hiding this comment.
Looks good, just left one nit. Thanks a lot, @jorgemcgomes for spotting the bug!
| self.decay = self.get_decay(self.optimization_step) | ||
|
|
||
| # Compute the decay factor for the exponential moving average. | ||
| current_decay = (1 + self.optimization_step) / (10 + self.optimization_step) |
Contributor
There was a problem hiding this comment.
(nit) this is not the current decay, current decay is
min(decay, (1 + self.optimization_step) / (10 + self.optimization_step))
Member
Author
There was a problem hiding this comment.
You are right! I didn't like value because it doesn't mean anything, but will go back to it because can't think of anything better right now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1864