Skip to content

enh(fortran) support intrinsic data types & better 0 width match error detection #2379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 6, 2020
Merged

enh(fortran) support intrinsic data types & better 0 width match error detection #2379

merged 3 commits into from
Feb 6, 2020

Conversation

@joshgoebel
Copy link
Member

@joshgoebel joshgoebel commented Jan 31, 2020 •
edited
Loading

Closes #1723.
Closes #2140.

@joshgoebel joshgoebel requested a review from egor-rogov January 31, 2020 22:52
@joshgoebel joshgoebel added enhancement An enhancement or new feature language labels Jan 31, 2020
@joshgoebel joshgoebel mentioned this pull request Jan 31, 2020
Closed
@joshgoebel
enh(fortran) support intrinsic data types
e0c0405 
Closes highlightjs#1723.
@joshgoebel
(parser) throw "0 width match" error for bad regex
61a5452 
Closes highlightjs#2140.

- In safe mode 0 width matches will be safely and quietly ignored
  and advance the cursor 1 step, as before.
- In debug mode a "0 width match" error will be thrown.

This should help prevent such misbehaved rules from sneaking back
into the library in the future.
@joshgoebel joshgoebel added this to the 10.0 milestone Jan 31, 2020
@joshgoebel joshgoebel changed the title enh(fortran) support intrinsic data types enh(fortran) support intrinsic data types & better 0 width match error detection Jan 31, 2020
@joshgoebel joshgoebel added the bug label Feb 2, 2020
egor-rogov
egor-rogov approved these changes Feb 6, 2020
View reviewed changes
Copy link
Collaborator

@egor-rogov egor-rogov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@joshgoebel joshgoebel merged commit 7be9dc8 into highlightjs:master Feb 6, 2020
taufik-nurrohman pushed a commit to taufik-nurrohman/highlight.js that referenced this pull request Feb 18, 2020
@joshgoebel @taufik-nurrohman
enh(fortran) support intrinsic data types & better 0 width match erro…
b6097c5 
…r detection (highlightjs#2379)

* enh(fortran) support intrinsic data types

Closes highlightjs#1723.

* (parser) throw "0 width match" error for bad regex

Closes highlightjs#2140.

- In safe mode 0 width matches will be safely and quietly ignored
  and advance the cursor 1 step, as before.
- In debug mode a "0 width match" error will be thrown.

This should help prevent such misbehaved rules from sneaking back
into the library in the future.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@egor-rogov egor-rogov egor-rogov approved these changes

Assignees

No one assigned

Labels

bug enhancement An enhancement or new feature language parser

Projects

None yet

Milestone

10.0 Spring Relase

Development

Successfully merging this pull request may close these issues.

Some existing rules are unrepeatable and should be corrected issue in highlighting fortran code: kind of intrinsic data type

2 participants

@joshgoebel @egor-rogov