issue in highlighting fortran code: kind of intrinsic data type

[kookma]

In modern fortran you can set the kind of intrinsic data type. It means you can define additional intrinsic data type. When you do so, for literal constants you have to use the kind name attached to literal consonant using under score.

Example

PROGRAM test_initial
INTEGER, PARAMETER :: DBL = SELECTED_REAL_KIND(p=13)
REAL(KIND=DBL) :: a1 = 6.666666666666666
REAL(KIND=DBL) :: a2 = 6.666666666666666_DBL
WRITE (*,*) a1, a2
END PROGRAM test_initial

Highlight.js issue

When using highlight.js to highlight a Fortran code contains such named constant, highlight.js fails to do the job! It highlights the remaining code (from the position of named constant) in a wrong way!

Note

• The above code in this post is highlighted by github, it works correctly! See the name constant is in blue color.
• other intrinsic data can have other kind. But in all cases in named constants, the kind is specified by an underscore to the constant (e.g 12_ps)

[kookma]

Solution

This is the solution to the above question.
The "number" class in fortran.js file shall be corrected as bellow:

{
        className: 'number',
        begin: '(?=\\b|\\+|\\-|\\.)[+-]?(?:\\.|\\d+\\.?)\\d*([de][+-]?\\d+)?(_[a-z\\d]+)?\\b',
        relevance: 0
      }

[kookma]

Is there any chance to be merged in the new revision of main release?

[egor-rogov]

@kookma Could you make a PR out of this (plus some tests)?

[kookma]

Sure, but I don't know how to make a PR? Should I fork this repo?

[egor-rogov]

Yes, first fork the repo and commit changes to it. Then in your repo on "Pull requests" tab find "New pull request" button.

[kookma]

@egor-rogov
Sure, I do it.

[kookma]

@egor-rogov
Please have a look at: #1934

[joshgoebel]

See also #1566

[kookma]

@yyyc514
Thank you for following up this issue!
Highlight.js is used in many webpages have Fortran stuffs so it worth to correct the issue!
I saw #1566 and will try that!
My simple solution above works for me but I am not a regex expert to see if the solution is correct or not!

[kookma]

@yyyc514
I check the new fix on https://jsfiddle.net/ajoshguy/nagkqytv/11/
by trying the below code:

<pre>
<code class="fortran">
program main
! This is a test
real :: x, y
x=1.23_wp
y=0._wer
z=1.25e9
end program main
</code>
</pre>

And it seems you solution from #1566 works!

So, I think you can to close this issue.