Skip to content

Resolving the timeout exceptions we've seen on CI #1367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 13, 2017
Merged

Resolving the timeout exceptions we've seen on CI #1367

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d7a7e93
HSEARCH-2681 Improve Elasticsearch backend diagnostic
Sanne Apr 12, 2017
f7d7f05
HSEARCH-2681 Disable lease handling on the Non-blocking HTTP client c…
Sanne Apr 12, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .../main/java/org/hibernate/search/elasticsearch/client/impl/DefaultElasticsearchClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ public Response execute(ElasticsearchRequest request) throws IOException {
);
}
catch (ResponseException e) {
requestLog.debug( "ES client issued a ResponseException - not necessarily a problem", e );
/*
* The client tries to guess what's an error and what's not, but it's too naive.
* A 404 on DELETE is not always important to us, for instance.
Expand Down
1 change: 1 addition & 0 deletions ...ava/org/hibernate/search/elasticsearch/client/impl/DefaultElasticsearchClientFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,7 @@ private HttpAsyncClientBuilder customizeHttpClientConfig(String propertyPrefix,

private RequestConfig.Builder customizeRequestConfig(String propertyPrefix, Properties properties, RequestConfig.Builder builder) {
return builder
.setConnectionRequestTimeout( 0 ) //Disable lease handling for the connection pool! See also HSEARCH-2681
.setSocketTimeout( ConfigurationParseHelper.getIntValue(
properties,
propertyPrefix + ElasticsearchEnvironment.SERVER_READ_TIMEOUT,
Expand Down
2 changes: 1 addition & 1 deletion ...csearch/src/test/java/org/hibernate/search/elasticsearch/testutil/ImportedTestRunner.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
*<p>Adapt the classname filter as needed to run a single test or an entire test package.
*
* <p>Running such tests from the IDE will require having an Elasticsearch
* node running. You can easily start one by running 'mvn elasticsearch:run'
* node running. You can easily start one by running 'mvn elasticsearch:runforked'
* from the elasticsearch module in this project.
*
* @author Gunnar Morling
Expand Down