Skip to content

Conversation

@Sanne
Copy link
Member

@Sanne Sanne commented Apr 12, 2017

See also JIRA description for the explanation:

Copy link
Member

@yrodiere yrodiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see this fixed :) I'll trust you on the validity of the fix, since I can't reproduce the problem locally...
Will merge as soon as the build passed.

@Sanne
Copy link
Member Author

Sanne commented Apr 12, 2017

retest this please

@Sanne
Copy link
Member Author

Sanne commented Apr 12, 2017

@Hibernate-CI test this please

@yrodiere
Copy link
Member

yrodiere commented Apr 12, 2017

@Sanne About the failure we had sooner, related to a malformed HTTP response: I created a JIRA. https://hibernate.atlassian.net/browse/HSEARCH-2682

@yrodiere
Copy link
Member

Jenkins, retest this please

@yrodiere yrodiere merged commit f7d7f05 into hibernate:master Apr 13, 2017
@yrodiere
Copy link
Member

Merged. Thanks!

@Sanne Sanne deleted the HSEARCH-2681 branch April 13, 2017 09:58
@atulsudhalkar
Copy link

Did this fix make into any recent ES releases? I'm running into the same exception, but I'm on ES 6.2!

@yrodiere
Copy link
Member

yrodiere commented Jun 1, 2018

@atulsudhalkar Here is the issue on the Elasticsearch bugtracker: elastic/elasticsearch#24069

It seems a fix was merged on March 28 EDIT: May 4, my bad.

I don't know about Elasticsearch 6.2, since Hibernate Search currently only support 5.x, but on 5.6 at least the workaround added in this PR works just fine.

@Sanne
Copy link
Member Author

Sanne commented Jun 1, 2018

It was eventually resolved via elastic/elasticsearch#30384

So Elasticsearch I expect it fixed in versions 6.3.1, 6.4.0, 7.

@atulsudhalkar
Copy link

atulsudhalkar commented Jun 1, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants