Skip to content

Conversation

@northeastprince
Copy link
Collaborator

No description provided.

@northeastprince northeastprince linked an issue Dec 10, 2023 that may be closed by this pull request
Copy link
Member

@garyhtou garyhtou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this idea! To make sure we're on the same page:

  • If hackathon is less than 1 month from now, list it every time
  • If hackathon is more than 1 month from now, list it every 3 months

Maybe we should update it to every 1 month

@garyhtou
Copy link
Member

Another way to approach this problem is:

# sudo code

def black_list # there's prob a better name
  # hackathons that are more than 1 month away and have been listed within the past 3 months for this recipient
end

applicable_listings.remove(black_list).first(MAX_LISTINGS)

This would make fewer queries to the DB I think

@garyhtou
Copy link
Member

garyhtou commented Jan 2, 2024

Is there anything blocking this PR?

@northeastprince northeastprince changed the title Don't list hackathons in every digest if it's more than a month out Only list hackathons every 3 months if it's more than a month out Jan 3, 2024
@northeastprince northeastprince changed the title Only list hackathons every 3 months if it's more than a month out Only list hackathons in digests every 3 months if it's more than a month out Jan 3, 2024
@northeastprince northeastprince merged commit 8e96fea into main Jan 3, 2024
@northeastprince northeastprince deleted the every-3-months branch January 3, 2024 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Digest schedule

3 participants