I DECLARE BANKRUPTCY #237
Closed
I DECLARE BANKRUPTCY #237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
northeastprince
commented
Sep 19, 2023
sampoder
reviewed
Sep 20, 2023
northeastprince
commented
Sep 26, 2023
northeastprince
commented
Sep 26, 2023
northeastprince
commented
Sep 26, 2023
northeastprince
commented
Sep 28, 2023
Co-authored-by: Matt Almeida <[email protected]>
Co-authored-by: Matt Almeida <[email protected]>
Co-authored-by: Matt Almeida <[email protected]>
sampoder
force-pushed
the
dont-send-redundant-digests
branch
from
0e86e08 to
fad24d3
Compare
sampoder
reviewed
Sep 28, 2023
garyhtou
reviewed
Nov 2, 2023
Comment on lines
+10
to
+19
| @new_listings_by_subscription = @digest.listings | ||
| .includes(:subscription, hackathon: {logo_attachment: :blob}) | ||
| .select { |listing| listing.previously_listed_for_recipient? } | ||
| .group_by(&:subscription) | ||
|
|
||
| @previous_listings_by_subscription = @digest.listings | ||
| .includes(:subscription, hackathon: {logo_attachment: :blob}) | ||
| .reject { |listing| listing.previously_listed_for_recipient? } | ||
| .group_by(&:subscription) | ||
|
|
|
Don't think this is needed with #352 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sampoder