-
Notifications
You must be signed in to change notification settings - Fork 103
Update tests #145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tests #145
Conversation
|
@michaelmior It appears that the current merge strategy is breaking all of my commit signatures and causing them to be marked as "Unverified": Commits in every PRCommits after mergingIs it possible to merge PRs without rewriting the git history? I don't know if this is being enforced by a repo setting like "Require a linear git history" or some such, but wanted to ask. |
|
I prefer keeping linear history where possible. If you want your commits to show as verified, the easiest way to have both these happen is to make sure that your PR is rebased on the latest master branch. |
#143 was based on then-current Would you consider forgoing your preference for a linear history? |
|
@kurtmckee Personally I find the benefit of a linear history greater than the benefit of verified commits. |
|
Okay. |


This PR overhauls the test suite in several ways:
All tests are parametrized where possible -- tests no longer use
forloops.This has resulted in a jump in test visibility from 171 tests to 307 tests.
The
jsonpath_ngandjsonpath_ng.extparsers are now tested in lock step -- inconsistently quadruplicated test cases have been consolidated.Fixtures have been introduced to control
auto_id.The test suite is now at 100% code coverage.
pytest-randomlyhas been introduced to randomize the order of test modules and test cases, which helps demonstrate that tests are fully isolated from each other.All files have been run through black, isort, and pyupgrade.