Skip to content

Add polyfill for CustomEvent to fix #1186 #1187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 5, 2020
Merged

Add polyfill for CustomEvent to fix #1186 #1187

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c5c5c38
Add polyfill for CustomEvent to fix #1186
phil-blais Mar 5, 2020
f1ec3e2
Scope the CustomEvent polyfill
phil-blais Mar 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions src/gridstack-poly.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,22 @@
* gridstack.js may be freely distributed under the MIT license.
*/

// https://developer.mozilla.org/en-US/docs/Web/API/CustomEvent/CustomEvent
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

site has it wrapped in a function it calls.. maybe to scope the CustomEvent var ? I would do the same please.

Copy link
Author

@phil-blais phil-blais Mar 5, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My mistake. Thought the whole poly file was scoped for some reason. Updated.

(function () {
if (typeof window.CustomEvent === "function") {
return false;
}

function CustomEvent (event, params) {
params = params || {bubbles: false, cancelable: false, detail: null};
var evt = document.createEvent('CustomEvent');
evt.initCustomEvent(event, params.bubbles, params.cancelable, params.detail);
return evt;
}

window.CustomEvent = CustomEvent;
})();

// https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Number/isNaN
Number.isNaN = Number.isNaN || function isNaN(input) {
return typeof input === 'number' && input !== input;
Expand Down