Add polyfill for CustomEvent to fix #1186 #1187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adumesny
reviewed
Mar 5, 2020
| * gridstack.js may be freely distributed under the MIT license. | ||
| */ | ||
|
|
||
| // https://developer.mozilla.org/en-US/docs/Web/API/CustomEvent/CustomEvent |
There was a problem hiding this comment.
site has it wrapped in a function it calls.. maybe to scope the CustomEvent var ? I would do the same please.
There was a problem hiding this comment.
My mistake. Thought the whole poly file was scoped for some reason. Updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please explain the changes you made here. Include an example of what your changes fix or how to use the changes.
Checklist
yarn test)