Skip to content

Correctly propagate help_text as description for many-to-* relations #579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 10, 2019
Merged

Correctly propagate help_text as description for many-to-* relations #579

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
61d20d3
Correctly propagate help_text as description for many-to-* relations
Feb 4, 2019
11c69af
Merge branch 'master' into many-help-text
jkimbo Jun 9, 2019
f1c885e
Trigger build
jkimbo Jun 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions graphene_django/converter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,8 @@ def dynamic_type():
if not _type:
return

description = field.help_text if isinstance(field, models.ManyToManyField) else field.field.help_text

# If there is a connection, we should transform the field
# into a DjangoConnectionField
if _type._meta.connection:
Expand All @@ -186,11 +188,11 @@ def dynamic_type():
if _type._meta.filter_fields or _type._meta.filterset_class:
from .filter.fields import DjangoFilterConnectionField

return DjangoFilterConnectionField(_type)
return DjangoFilterConnectionField(_type, description=description)

return DjangoConnectionField(_type)
return DjangoConnectionField(_type, description=description)

return DjangoListField(_type)
return DjangoListField(_type, description=description)

return Dynamic(dynamic_type)

Expand Down