Correctly propagate help_text as description for many-to-* relations #579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danpalmer
approved these changes
Mar 20, 2019
Collaborator
danpalmer
left a comment
danpalmer
left a comment
There was a problem hiding this comment.
LGTM.
Would be nice if there was an API method on these fields that would correctly traverse the field structure to pull out the help text in all cases. If you can find something then great, but with a quick look I can't see anything obvious so I think this is 👍.
firaskafri
approved these changes
Mar 21, 2019
Member
|
The lint tests are failing. Looks good once those are fixed |
Member
|
@mvanlonden looks like it just needed to be brought up to date with master. Thanks @alexkirsz ! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ManyTo* relations' help_text was getting lost in translation when converted to graphene-django types. This PR correctly propagates it.