Add sparse enum decoding benchmarks #984
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With upcoming change we'll improve decoding performance of enums, but there will be a difference between "sparse" and "dense" enum decoding performance, even though they'll both be faster.
To be able to measure the difference add a "sparse" enum type and a benchmark for decoding it.
"Sparse" means the enum has large gaps between known enum values, or negative enum values.
When decoding this kind of enums, the mapping from the wire
varintto the Dart value for the enum needs to be done by binary search, map lookup, or similar.For "dense" enums, we can have a list of enum values and index the list directly with the
varintvalue, after a range check.These changes will be done in the follow-up PR(s).