Fix factory argument types for map fields #976
Conversation
|
I think we could just publish this. Any thoughts @devoncarew? I can bump the version number to non-wip.
|
devoncarew
left a comment
devoncarew
left a comment
There was a problem hiding this comment.
lgtm
I think we could just publish this. Any thoughts @devoncarew? I can bump the version number to non-wip.
For many commonly used packages, we like to roll into the sdk and the then google3 before publishing in order to shake out any issues. This package is lightly used in the sdk (so testing there would be useful but less critical), and afaik doesn't roll into google3 anymore.
I think landing this and rolling into the sdk would make sense; we could roll the commits for both this and #959 together.
If that looks good, we can rev the version here and publish (we don't need to validate a version only change in other repos before publishing).
|
I tested this internally in cl/755740416, merging. |
Revisions updated by `dart tools/rev_sdk_deps.dart`. dartdoc (https://github.com/dart-lang/dartdoc/compare/e4f9451..95f4208): 95f4208e 2025-05-12 Sam Rawlins Simplify Inheritable.computeCanonicalEnclosingContainer. (dart-lang/dartdoc#4047) http (https://github.com/dart-lang/http/compare/78d6114..e70a41b): e70a41b 2025-05-09 Brian Quinlan Clarify that some headers may not be sent/received (dart-lang/http#1768) d99cc3c 2025-05-07 Brian Quinlan Return a customized `StreamedResponse` from `CronetClient.send` (dart-lang/http#1769) 6b92d99 2025-05-07 JohnettJobben1 [web_socket_channel] Shorten library description for pub score improvement (dart-lang/http#1737) 31da355 2025-05-05 Brian Quinlan Prepare cronet_http/cupertino_http/http/web_socket for release (dart-lang/http#1767) dfbe73d 2025-05-05 Brian Quinlan Ignore received data after the response stream has been closed (dart-lang/http#1766) protobuf (https://github.com/dart-lang/protobuf/compare/1aaa332..7d2e615): 7d2e615 2025-05-12 Agam Agarwal Add fromDart() and toDart() methods to convert between $core.Duration and proto Duration (google/protobuf.dart#986) e4fca16 2025-05-12 Ömer Sinan Ağacan Add sparse enum decoding benchmarks (google/protobuf.dart#984) 006d3aa 2025-05-09 Ömer Sinan Ağacan Update protoc_plugin pre-generated protos (google/protobuf.dart#982) 4abee01 2025-05-09 Ömer Sinan Ağacan Sort input proto files before processing (google/protobuf.dart#983) 60e23f1 2025-05-07 Ömer Sinan Ağacan Fix factory argument types for map fields (google/protobuf.dart#976) de6bcc2 2025-05-07 Ömer Sinan Ağacan Fix packed enum decoding benchmark (google/protobuf.dart#979) 9daf5ca 2025-05-06 Ömer Sinan Ağacan Improve packed field decoding (google/protobuf.dart#959) tools (https://github.com/dart-lang/tools/compare/92f10a9..36f5c9f): 36f5c9f9 2025-05-05 Jacob MacDonald broaden the publish tag regex to allow digits (dart-lang/tools#2085) c6a10613 2025-05-05 Goddchen fix(clock): keep micros in monthsAgo, monthsFromNow and yearsAgo (dart-lang/tools#1202) f1f8ac18 2025-05-02 Liam Appelbe [coverage] Fix another flaky lifecycle management error (dart-lang/tools#2082) webdev (https://github.com/dart-lang/webdev/compare/5bf833d..1ea8462): 1ea84624 2025-05-08 Nicholas Shahan [gardening] Temporarily skip failing test case (dart-lang/webdev#2618) Change-Id: I193c34b97e7acf1cf52c91240765344e47424b73 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/428100 Commit-Queue: Konstantin Shcheglov <[email protected]> Auto-Submit: Devon Carew <[email protected]> Reviewed-by: Konstantin Shcheglov <[email protected]>
|
@devoncarew #981 is almost ready but internal testing reveals a failure. I'm not sure yet whether it's related to the patch or a failure that already exists, but it's in a Dart test so I need to investigate it further tomorrow. Making a release today without the enum patch SGTM. (but we should fix the plugin version number as you noted in #986 (comment)) |
|
Makes sense! version rev. PR out: #989 |
2 participants
Fixes #975.
cl/809933607