Remove dart_style dependency, formatting in grpc files #702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The grpc generator was implemented in the internal version in cl/175674584.
f2a9c14 ported it to open source, and differently than internal version, it
used dart_style to format grpc files. However other files were not formatted.
To keep things simpler (avoid a dependency in internal version) and the two
code bases in sync, this PR removes dart_style dependency and formatting grpc
files.
We can later discuss whether we want to generate formatted files and add
dart_style back, and use it consistently in all of the generators. (#368)