Generated code does not comply with dartfmt standards

[bobjackman]

After generating dart files, said files are not compliant with dartfmt standards. This has the effect of causing builds to fail (several package developers require proper formatting in order to contribute) as well as significant score deductions employed by dart.dev itself when an author publishes a package that includes files generated by this library.

The gRPC lib should either run dartfmt or natively generate compliant code in order to avoid significant problems for authors that may choose to use this lib.

[bobjackman]

@sigurdm @jakobr-google @sgjesse @kevmoo @szakarias

[sigurdm]

If you have the resources you could attempt at making a PR.
I think we want this feature, but it is not high on our priority list.

Otherwise I would suggest running dartfmt on the generated code in a separate step. That works fine.

[kevmoo]

@mit-mit ?

[osa1]

We generate formatted code for .pbgrpc.dart files:

protobuf.dart/protoc_plugin/lib/src/file_generator.dart

Line 530 in 7eb48c8

return _formatter.format(out.toString());

That code was added in f2a9c14, but that commit didn't change other generators to generate formatted code. No idea why an exception was made to grpc files.

We could easily update rest of the code generators to generate formatted code too. I don't know if it will be significantly slower. Probably worth benchmarking on some large-ish protos.

If users always format the generated code, generating formatted code will probably be faster than generating unformatted + running formatter.

@sigurdm points out that dart format <file> can format differently than protoc_plugin's formatting as it's possible that those two will use different versions of dart_style.