Skip to content

Follow symlinks in MkdirAllAt #11911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 14, 2025
Merged

Follow symlinks in MkdirAllAt #11911

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions pkg/sentry/vfs/vfs.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -878,7 +878,16 @@ func (vfs *VirtualFilesystem) MkdirAllAt(ctx context.Context, currentPath string
Start: root,
Path: fspath.Parse(currentPath),
}

// For the StatAt() operation, we follow final symlinks so that we don't
// produce errors when the final component is a symlink to a directory.
//
// However, keep the old pop unchanged when passing to MkdirAt() below
// because MkdirAt() must not follow the final symlink. This is enforced
// by preconditions of FilesystemImpl.MkdirAt().
pop.FollowFinalSymlink = true
stat, err := vfs.StatAt(ctx, creds, pop, &StatOptions{Mask: linux.STATX_TYPE})
pop.FollowFinalSymlink = false
switch {
case err == nil:
if mustBeDir && (stat.Mask&linux.STATX_TYPE == 0 || stat.Mode&linux.FileTypeMask != linux.ModeDirectory) {
Expand Down