Follow symlinks in MkdirAllAt #11911
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
thanks for the fix. Could you wrap the commit message at 80 chars. |
Contributor
Author
|
Yes, can do! Thanks for this. Also let me know if you have guidance on how to write a test for this behavior! |
Contributor
Author
|
Just wrapped the commit message, thanks! |
copybara-service bot
pushed a commit
that referenced
this pull request
Jul 10, 2025
See #11910 for details — this potentially fixes a divergence between gVisor and runc behavior where having the `cwd` of the OCI container spec set to a symlink to a folder causes gVisor to exit with this error: ``` running container: starting container: starting root container: starting sandbox: failed to create process working directory "/cwd-folder-name-here": not a directory ``` FUTURE_COPYBARA_INTEGRATE_REVIEW=#11911 from ekzhang:patch-1 57017a5 PiperOrigin-RevId: 781612832
copybara-service bot
pushed a commit
that referenced
this pull request
Jul 11, 2025
See #11910 for details — this potentially fixes a divergence between gVisor and runc behavior where having the `cwd` of the OCI container spec set to a symlink to a folder causes gVisor to exit with this error: ``` running container: starting container: starting root container: starting sandbox: failed to create process working directory "/cwd-folder-name-here": not a directory ``` FUTURE_COPYBARA_INTEGRATE_REVIEW=#11911 from ekzhang:patch-1 57017a5 PiperOrigin-RevId: 781612832
copybara-service bot
pushed a commit
that referenced
this pull request
Jul 11, 2025
See #11910 for details — this potentially fixes a divergence between gVisor and runc behavior where having the `cwd` of the OCI container spec set to a symlink to a folder causes gVisor to exit with this error: ``` running container: starting container: starting root container: starting sandbox: failed to create process working directory "/cwd-folder-name-here": not a directory ``` FUTURE_COPYBARA_INTEGRATE_REVIEW=#11911 from ekzhang:patch-1 57017a5 PiperOrigin-RevId: 781612832
copybara-service bot
pushed a commit
that referenced
this pull request
Jul 11, 2025
See #11910 for details — this potentially fixes a divergence between gVisor and runc behavior where having the `cwd` of the OCI container spec set to a symlink to a folder causes gVisor to exit with this error: ``` running container: starting container: starting root container: starting sandbox: failed to create process working directory "/cwd-folder-name-here": not a directory ``` FUTURE_COPYBARA_INTEGRATE_REVIEW=#11911 from ekzhang:patch-1 57017a5 PiperOrigin-RevId: 781612832
copybara-service bot
pushed a commit
that referenced
this pull request
Jul 11, 2025
See #11910 for details — this potentially fixes a divergence between gVisor and runc behavior where having the `cwd` of the OCI container spec set to a symlink to a folder causes gVisor to exit with this error: ``` running container: starting container: starting root container: starting sandbox: failed to create process working directory "/cwd-folder-name-here": not a directory ``` FUTURE_COPYBARA_INTEGRATE_REVIEW=#11911 from ekzhang:patch-1 57017a5 PiperOrigin-RevId: 781612832
copybara-service bot
pushed a commit
that referenced
this pull request
Jul 11, 2025
See #11910 for details — this potentially fixes a divergence between gVisor and runc behavior where having the `cwd` of the OCI container spec set to a symlink to a folder causes gVisor to exit with this error: ``` running container: starting container: starting root container: starting sandbox: failed to create process working directory "/cwd-folder-name-here": not a directory ``` FUTURE_COPYBARA_INTEGRATE_REVIEW=#11911 from ekzhang:patch-1 57017a5 PiperOrigin-RevId: 781612832
copybara-service bot
pushed a commit
that referenced
this pull request
Jul 11, 2025
See #11910 for details — this potentially fixes a divergence between gVisor and runc behavior where having the `cwd` of the OCI container spec set to a symlink to a folder causes gVisor to exit with this error: ``` running container: starting container: starting root container: starting sandbox: failed to create process working directory "/cwd-folder-name-here": not a directory ``` FUTURE_COPYBARA_INTEGRATE_REVIEW=#11911 from ekzhang:patch-1 57017a5 PiperOrigin-RevId: 781612832
copybara-service bot
pushed a commit
that referenced
this pull request
Jul 11, 2025
See #11910 for details — this potentially fixes a divergence between gVisor and runc behavior where having the `cwd` of the OCI container spec set to a symlink to a folder causes gVisor to exit with this error: ``` running container: starting container: starting root container: starting sandbox: failed to create process working directory "/cwd-folder-name-here": not a directory ``` FUTURE_COPYBARA_INTEGRATE_REVIEW=#11911 from ekzhang:patch-1 57017a5 PiperOrigin-RevId: 781612832
Collaborator
|
@ekzhang tests fail wtih this change: https://buildkite.com/gvisor/pipeline/builds/36763#0197f79a-ae2d-49aa-8215-37930715c36d |
Contributor
Author
|
Got it, yeah I see I should fix this test, will do that — but is the general approach correct or would you want it to be adjusted? |
Collaborator
yes, it is correct. |
copybara-service bot
pushed a commit
that referenced
this pull request
Jul 11, 2025
See #11910 for details — this potentially fixes a divergence between gVisor and runc behavior where having the `cwd` of the OCI container spec set to a symlink to a folder causes gVisor to exit with this error: ``` running container: starting container: starting root container: starting sandbox: failed to create process working directory "/cwd-folder-name-here": not a directory ``` FUTURE_COPYBARA_INTEGRATE_REVIEW=#11911 from ekzhang:patch-1 3bd7a45 PiperOrigin-RevId: 781612832
ayushr2
reviewed
Jul 11, 2025
copybara-service bot
pushed a commit
that referenced
this pull request
Jul 11, 2025
See #11910 for details — this potentially fixes a divergence between gVisor and runc behavior where having the `cwd` of the OCI container spec set to a symlink to a folder causes gVisor to exit with this error: ``` running container: starting container: starting root container: starting sandbox: failed to create process working directory "/cwd-folder-name-here": not a directory ``` FUTURE_COPYBARA_INTEGRATE_REVIEW=#11911 from ekzhang:patch-1 3bd7a45 PiperOrigin-RevId: 781612832
copybara-service bot
pushed a commit
that referenced
this pull request
Jul 11, 2025
See #11910 for details — this potentially fixes a divergence between gVisor and runc behavior where having the `cwd` of the OCI container spec set to a symlink to a folder causes gVisor to exit with this error: ``` running container: starting container: starting root container: starting sandbox: failed to create process working directory "/cwd-folder-name-here": not a directory ``` FUTURE_COPYBARA_INTEGRATE_REVIEW=#11911 from ekzhang:patch-1 3bd7a45 PiperOrigin-RevId: 781612832
See google#11910 for details — this potentially fixes a divergence between gVisor and runc behavior where having the `cwd` of the OCI container spec set to a symlink to a folder causes gVisor to exit with this error: ``` running container: starting container: starting root container: starting sandbox: failed to create process working directory "/cwd-folder-name-here": not a directory ```
copybara-service bot
pushed a commit
that referenced
this pull request
Jul 11, 2025
See #11910 for details — this potentially fixes a divergence between gVisor and runc behavior where having the `cwd` of the OCI container spec set to a symlink to a folder causes gVisor to exit with this error: ``` running container: starting container: starting root container: starting sandbox: failed to create process working directory "/cwd-folder-name-here": not a directory ``` FUTURE_COPYBARA_INTEGRATE_REVIEW=#11911 from ekzhang:patch-1 3f7bca1 PiperOrigin-RevId: 781612832
copybara-service bot
pushed a commit
that referenced
this pull request
Jul 11, 2025
See #11910 for details — this potentially fixes a divergence between gVisor and runc behavior where having the `cwd` of the OCI container spec set to a symlink to a folder causes gVisor to exit with this error: ``` running container: starting container: starting root container: starting sandbox: failed to create process working directory "/cwd-folder-name-here": not a directory ``` FUTURE_COPYBARA_INTEGRATE_REVIEW=#11911 from ekzhang:patch-1 3f7bca1 PiperOrigin-RevId: 781612832
copybara-service bot
pushed a commit
that referenced
this pull request
Jul 11, 2025
See #11910 for details — this potentially fixes a divergence between gVisor and runc behavior where having the `cwd` of the OCI container spec set to a symlink to a folder causes gVisor to exit with this error: ``` running container: starting container: starting root container: starting sandbox: failed to create process working directory "/cwd-folder-name-here": not a directory ``` FUTURE_COPYBARA_INTEGRATE_REVIEW=#11911 from ekzhang:patch-1 3f7bca1 PiperOrigin-RevId: 781612832
copybara-service bot
pushed a commit
that referenced
this pull request
Jul 11, 2025
See #11910 for details — this potentially fixes a divergence between gVisor and runc behavior where having the `cwd` of the OCI container spec set to a symlink to a folder causes gVisor to exit with this error: ``` running container: starting container: starting root container: starting sandbox: failed to create process working directory "/cwd-folder-name-here": not a directory ``` FUTURE_COPYBARA_INTEGRATE_REVIEW=#11911 from ekzhang:patch-1 3f7bca1 PiperOrigin-RevId: 781612832
copybara-service bot
pushed a commit
that referenced
this pull request
Jul 12, 2025
See #11910 for details — this potentially fixes a divergence between gVisor and runc behavior where having the `cwd` of the OCI container spec set to a symlink to a folder causes gVisor to exit with this error: ``` running container: starting container: starting root container: starting sandbox: failed to create process working directory "/cwd-folder-name-here": not a directory ``` FUTURE_COPYBARA_INTEGRATE_REVIEW=#11911 from ekzhang:patch-1 3f7bca1 PiperOrigin-RevId: 781612832
copybara-service bot
pushed a commit
that referenced
this pull request
Jul 12, 2025
See #11910 for details — this potentially fixes a divergence between gVisor and runc behavior where having the `cwd` of the OCI container spec set to a symlink to a folder causes gVisor to exit with this error: ``` running container: starting container: starting root container: starting sandbox: failed to create process working directory "/cwd-folder-name-here": not a directory ``` FUTURE_COPYBARA_INTEGRATE_REVIEW=#11911 from ekzhang:patch-1 3f7bca1 PiperOrigin-RevId: 781612832
copybara-service bot
pushed a commit
that referenced
this pull request
Jul 12, 2025
See #11910 for details — this potentially fixes a divergence between gVisor and runc behavior where having the `cwd` of the OCI container spec set to a symlink to a folder causes gVisor to exit with this error: ``` running container: starting container: starting root container: starting sandbox: failed to create process working directory "/cwd-folder-name-here": not a directory ``` FUTURE_COPYBARA_INTEGRATE_REVIEW=#11911 from ekzhang:patch-1 3f7bca1 PiperOrigin-RevId: 781612832
copybara-service bot
pushed a commit
that referenced
this pull request
Jul 13, 2025
See #11910 for details — this potentially fixes a divergence between gVisor and runc behavior where having the `cwd` of the OCI container spec set to a symlink to a folder causes gVisor to exit with this error: ``` running container: starting container: starting root container: starting sandbox: failed to create process working directory "/cwd-folder-name-here": not a directory ``` FUTURE_COPYBARA_INTEGRATE_REVIEW=#11911 from ekzhang:patch-1 3f7bca1 PiperOrigin-RevId: 781612832
copybara-service bot
pushed a commit
that referenced
this pull request
Jul 13, 2025
See #11910 for details — this potentially fixes a divergence between gVisor and runc behavior where having the `cwd` of the OCI container spec set to a symlink to a folder causes gVisor to exit with this error: ``` running container: starting container: starting root container: starting sandbox: failed to create process working directory "/cwd-folder-name-here": not a directory ``` FUTURE_COPYBARA_INTEGRATE_REVIEW=#11911 from ekzhang:patch-1 3f7bca1 PiperOrigin-RevId: 781612832
copybara-service bot
pushed a commit
that referenced
this pull request
Jul 13, 2025
See #11910 for details — this potentially fixes a divergence between gVisor and runc behavior where having the `cwd` of the OCI container spec set to a symlink to a folder causes gVisor to exit with this error: ``` running container: starting container: starting root container: starting sandbox: failed to create process working directory "/cwd-folder-name-here": not a directory ``` FUTURE_COPYBARA_INTEGRATE_REVIEW=#11911 from ekzhang:patch-1 3f7bca1 PiperOrigin-RevId: 781612832
copybara-service bot
pushed a commit
that referenced
this pull request
Jul 14, 2025
See #11910 for details — this potentially fixes a divergence between gVisor and runc behavior where having the `cwd` of the OCI container spec set to a symlink to a folder causes gVisor to exit with this error: ``` running container: starting container: starting root container: starting sandbox: failed to create process working directory "/cwd-folder-name-here": not a directory ``` Fixes #11910 FUTURE_COPYBARA_INTEGRATE_REVIEW=#11911 from ekzhang:patch-1 3f7bca1 PiperOrigin-RevId: 783024019
copybara-service bot
pushed a commit
that referenced
this pull request
Jul 14, 2025
See #11910 for details — this potentially fixes a divergence between gVisor and runc behavior where having the `cwd` of the OCI container spec set to a symlink to a folder causes gVisor to exit with this error: ``` running container: starting container: starting root container: starting sandbox: failed to create process working directory "/cwd-folder-name-here": not a directory ``` Fixes #11910 FUTURE_COPYBARA_INTEGRATE_REVIEW=#11911 from ekzhang:patch-1 3f7bca1 PiperOrigin-RevId: 783024019
This was referenced Jul 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #11910 for details — this potentially fixes a divergence between gVisor and runc behavior where having the
cwdof the OCI container spec set to a symlink to a folder causes gVisor to exit with this error:I'm not sure if this is the best way to fix the issue, just sending in the PR in case it helps!