Make expect_that! more hygienic
#476
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@eopb Thank you for the PR and sorry for the radio silence! Since September this change has developed a merge conflict with the code at HEAD, would you mind rebasing and replicating the fix across all the newly-added arms of the |
eopb
force-pushed
the
push-xprkkwruxvvw
branch
from
1bef56c to
77ce015
Compare
gribozavr
reviewed
Feb 17, 2025
eopb
force-pushed
the
push-xprkkwruxvvw
branch
2 times, most recently
from
2853d3a to
b5d154a
Compare
related google#475 I went for using fully qualified method names, rather than `use $crate::GoogleTestSupport as _;` since it's more hygienic. `use $crate::GoogleTestSupport as _;` can cause issues, resulting in a conflict, if the user introduces another method with the same name as one on `GoogleTestSupport`
eopb
force-pushed
the
push-xprkkwruxvvw
branch
from
b5d154a to
1a6ef3d
Compare
|
@gribozavr This should be ready now. I've only modified uses of the |
gribozavr
approved these changes
Feb 17, 2025
|
Thank you! Unless other reviewers leave more feedback, your PR should be merged soon by a bot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related #475
I went for using fully qualified method names, rather than
use $crate::GoogleTestSupport as _;since it's more hygienic.use $crate::GoogleTestSupport as _;can cause issues, resulting in a conflict, if the user introduces another method with the same name as one onGoogleTestSupport