Make expect_eq and friends more hygienic
#475
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, `expect_that!` doesn't work unless both `verify_eq!` and `verify_that` are in scope. This is okay or users of the prelude, but not for those who don't. I've noticed that googletest-rust has a number of other macro hygiene issue, but to avoid making an overly large PR, I'll address them as I come across them.
eopb
added a commit
to eopb/googletest-rust
that referenced
this pull request
Sep 3, 2024
related google#475 I went for using fully qualified method names, rather than `use $crate::GoogleTestSupport as _;` since it's more hygienic. `use $crate::GoogleTestSupport as _;` can cause issues, resulting in a conflict, if the user introduces another method with the same name as one on `GoogleTestSupport`
eopb
added a commit
to eopb/googletest-rust
that referenced
this pull request
Sep 3, 2024
related google#475 I went for using fully qualified method names, rather than `use $crate::GoogleTestSupport as _;` since it's more hygienic. `use $crate::GoogleTestSupport as _;` can cause issues, resulting in a conflict, if the user introduces another method with the same name as one on `GoogleTestSupport`
eopb
added a commit
to eopb/cargo-override
that referenced
this pull request
Sep 4, 2024
This requires extra imports because googletest macros look for items in the local scope. I've opened a PR to fix this google/googletest-rust#475 Once that is released, the extra imports will become unused.
eopb
added a commit
to eopb/cargo-override
that referenced
this pull request
Sep 4, 2024
This requires extra imports because googletest macros look for items in the local scope. I've opened a PR to fix this google/googletest-rust#475 Once that is released, the extra imports will become unused.
|
Thank you for the PR! Unfortunately it fell through the cracks and we didn't notice it. In the meantime other contributors have submitted similar fixes as well as the |
eopb
added a commit
to eopb/googletest-rust
that referenced
this pull request
Feb 17, 2025
related google#475 I went for using fully qualified method names, rather than `use $crate::GoogleTestSupport as _;` since it's more hygienic. `use $crate::GoogleTestSupport as _;` can cause issues, resulting in a conflict, if the user introduces another method with the same name as one on `GoogleTestSupport`
eopb
added a commit
to eopb/googletest-rust
that referenced
this pull request
Feb 17, 2025
related google#475 I went for using fully qualified method names, rather than `use $crate::GoogleTestSupport as _;` since it's more hygienic. `use $crate::GoogleTestSupport as _;` can cause issues, resulting in a conflict, if the user introduces another method with the same name as one on `GoogleTestSupport`
eopb
added a commit
to eopb/googletest-rust
that referenced
this pull request
Feb 17, 2025
related google#475 I went for using fully qualified method names, rather than `use $crate::GoogleTestSupport as _;` since it's more hygienic. `use $crate::GoogleTestSupport as _;` can cause issues, resulting in a conflict, if the user introduces another method with the same name as one on `GoogleTestSupport`
eopb
added a commit
to eopb/googletest-rust
that referenced
this pull request
Feb 17, 2025
related google#475 I went for using fully qualified method names, rather than `use $crate::GoogleTestSupport as _;` since it's more hygienic. `use $crate::GoogleTestSupport as _;` can cause issues, resulting in a conflict, if the user introduces another method with the same name as one on `GoogleTestSupport`
No worries. It's great to see the hygiene has improved since :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for googletest-rust. It's been awesome to use 🙌
Currently,
expect_that!doesn't work unless bothverify_eq!andverify_thatare in scope.This is okay or users of the prelude, but not for those who don't.
I've noticed that googletest-rust has a number of other macro hygiene issues, but to avoid making an overly large PR, I'll address them as I come across them.