Skip to content

Fix IndexError in ParallelAgent by adding events length check #3566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix IndexError in ParallelAgent by adding events length check #3566

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/google/adk/agents/llm_agent.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -471,7 +471,7 @@ async def _run_async_impl(
events = ctx._get_events(current_invocation=True, current_branch=True)
if events and (
ctx.should_pause_invocation(events[-1])
or ctx.should_pause_invocation(events[-2])
or (len(events) >= 2 and ctx.should_pause_invocation(events[-2]))
):
Comment on lines 472 to 475
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Nov 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While the fix is correct, the logic to check the last two events can be simplified and made more robust using a slice and any(). This avoids manual length checks and is more idiomatic. Using [::-1] on the slice preserves the evaluation order of checking the last event first.

      if any(ctx.should_pause_invocation(event) for event in events[-2:][::-1]):

return
# Only yield an end state if the last event is no longer a long running
Expand Down