Skip to content

Conversation

@enetheru
Copy link
Contributor

@enetheru enetheru commented Oct 13, 2025

The document originally written by me had some parts that were half finished, some errors I wanted to fix, and some additional things I wanted to address while I was working on it.

Original Problems

  • Remove the half done Toolchains section
  • fix /s/mutially inclusive/mutially exclusive
  • fix the command line examples to be more explicit and solve the error I saw with out of sequence assumptions.

Problems I saw while working on it.

  • respect the 80 column rule in prose and in code blocks.
  • re-arrange some sections for faster grokking
  • be very clear about who the examples are for
  • additional usage examples

Original PR

Doc Comment

@enetheru enetheru changed the title cmake-updates addressing my concerns listed in #541 cmake-updates deleting half done stuff, and fixing errors. Oct 13, 2025
- respect the 80 column rule
- be more explicit in code blocks
- re-arrange for faster grokking
- remove half made tested toolchain section
- fix /s/mutially inclusive/mutially exclusive
- remove old warning
- update examples
Copy link
Member

@Ivorforce Ivorforce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@Ivorforce Ivorforce requested a review from a team October 13, 2025 09:41
@Ivorforce Ivorforce added enhancement area:manual Issues and PRs related to the Manual/Tutorials section of the documentation topic:gdextension labels Oct 13, 2025
Thanks. for the fixes.

Co-authored-by: A Thousand Ships <[email protected]>
Co-authored-by: Lukas Tenbrink <[email protected]>
Copy link
Contributor

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks great to me :-)

@enetheru
Copy link
Contributor Author

This needs to be squashed yes? do the same rules apply across the godot repositories?

@Ivorforce
Copy link
Member

This needs to be squashed yes? do the same rules apply across the godot repositories?

Yep.

Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

I've merged with Squash and merge, so you don't need to squash commits manually when opening PRs on godot-docs. I also used this opportunity to reword the commit message.

@Calinou Calinou merged commit b61cd5d into godotengine:master Oct 14, 2025
1 check passed
@enetheru enetheru deleted the cmake-fix branch October 14, 2025 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:manual Issues and PRs related to the Manual/Tutorials section of the documentation cherrypick:4.5 enhancement topic:gdextension

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants