-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
cmake-updates deleting half done stuff, and fixing errors. #11370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- respect the 80 column rule - be more explicit in code blocks - re-arrange for faster grokking - remove half made tested toolchain section - fix /s/mutially inclusive/mutially exclusive - remove old warning - update examples
Ivorforce
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Thanks. for the fixes. Co-authored-by: A Thousand Ships <[email protected]> Co-authored-by: Lukas Tenbrink <[email protected]>
dsnopek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Looks great to me :-)
|
This needs to be squashed yes? do the same rules apply across the godot repositories? |
Yep. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
I've merged with Squash and merge, so you don't need to squash commits manually when opening PRs on godot-docs. I also used this opportunity to reword the commit message.
The document originally written by me had some parts that were half finished, some errors I wanted to fix, and some additional things I wanted to address while I was working on it.
Original Problems
Problems I saw while working on it.
Original PR
Doc Comment