[3.x] Update all to new toolchains, add Linux arm64 and arm32 builds #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
changed the title
GodotBuilder
force-pushed
the
3.x-update-f39-linux-arm64
branch
2 times, most recently
from
9defea8 to
c115b74
Compare
Backport of #89 and #90, in sync with godotengine/build-containers#135. In the 3.x branch, the situation with `arch` and `bits` is very brittle, so we only add the explicit `arch` argument for the arm32/arm64 builds. x86_32 still relies on `bits=32`. This would all be worth refactoring upstream like we did for 4.0, but it's a major undertaking and breaking change, which I'd prefer to avoid in 3.6. For Linux builds, we move the `strip` calls to the link stage, as this needs to be done with the arch-appropriate `strip` binary, so it's easier done there. In `master`, we now let the compiler strip automatically during the build if no debug symbols are requested, but this change wasn't backported to 3.x.
Member
Author
|
Tested successfully. |
GodotBuilder
force-pushed
the
3.x-update-f39-linux-arm64
branch
from
c115b74 to
0d2fbef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #89 and #90, in sync with godotengine/build-containers#135.
In the 3.x branch, the situation with
archandbitsis very brittle, so we only add the explicitarchargument for the arm32/arm64 builds. x86_32 still relies onbits=32.This would all be worth refactoring upstream like we did for 4.0, but it's a major undertaking and breaking change, which I'd prefer to avoid in 3.6.
For Linux builds, we move the
stripcalls to the link stage, as thisneeds to be done with the arch-appropriate
stripbinary, so it's easierdone there. In
master, we now let the compiler strip automaticallyduring the build if no debug symbols are requested, but this change
wasn't backported to 3.x.
Tested successfully for almost all platforms, I'm just battling some final issues with Linux arm32 (godotengine/godot#87258, and it looks like our buildroot will need to change its config to enable NEON intrinsics).
This is meant to be used with
3.x-f39-mono-6.12.0.198containers built from godotengine/build-containers#135.