Skip to content

Conversation

@akien-mga
Copy link
Member

@akien-mga
Copy link
Member Author

I'll update to remove the strip calls, we already strip binaries when building, and x86_64 strip can't strip arm binaries.

@GodotBuilder GodotBuilder force-pushed the linux-buildroot-update-arm branch from be46304 to 96b8f89 Compare November 1, 2023 16:46
@akien-mga akien-mga merged commit 2398d61 into main Nov 1, 2023
@akien-mga akien-mga deleted the linux-buildroot-update-arm branch November 1, 2023 16:47
GodotBuilder pushed a commit that referenced this pull request Jan 17, 2024
Backport of #89 and #90, in sync with godotengine/build-containers#135.

In the 3.x branch, the situation with `arch` and `bits` is very brittle,
so we only add the explicit `arch` argument for the arm32/arm64 builds.
x86_32 still relies on `bits=32`.

This would all be worth refactoring upstream like we did for 4.0, but
it's a major undertaking and breaking change, which I'd prefer to avoid
in 3.6.

For Linux builds, we move the `strip` calls to the build stage, as this
needs to be done with the arch-appropriate `strip` binary, so it's easier
done there. In `master`, we now let the compiler strip during the build
with `-s`, but this change wasn't backported to 3.x.
GodotBuilder pushed a commit that referenced this pull request Jan 17, 2024
Backport of #89 and #90, in sync with godotengine/build-containers#135.

In the 3.x branch, the situation with `arch` and `bits` is very brittle,
so we only add the explicit `arch` argument for the arm32/arm64 builds.
x86_32 still relies on `bits=32`.

This would all be worth refactoring upstream like we did for 4.0, but
it's a major undertaking and breaking change, which I'd prefer to avoid
in 3.6.

For Linux builds, we move the `strip` calls to the link stage, as this
needs to be done with the arch-appropriate `strip` binary, so it's easier
done there. In `master`, we now let the compiler strip automatically
during the build if no debug symbols are requested, but this change
wasn't backported to 3.x.
GodotBuilder pushed a commit that referenced this pull request Jan 17, 2024
Backport of #89 and #90, in sync with godotengine/build-containers#135.

In the 3.x branch, the situation with `arch` and `bits` is very brittle,
so we only add the explicit `arch` argument for the arm32/arm64 builds.
x86_32 still relies on `bits=32`.

This would all be worth refactoring upstream like we did for 4.0, but
it's a major undertaking and breaking change, which I'd prefer to avoid
in 3.6.

For Linux builds, we move the `strip` calls to the link stage, as this
needs to be done with the arch-appropriate `strip` binary, so it's easier
done there. In `master`, we now let the compiler strip automatically
during the build if no debug symbols are requested, but this change
wasn't backported to 3.x.
GodotBuilder pushed a commit that referenced this pull request Jan 18, 2024
Backport of #89 and #90, in sync with godotengine/build-containers#135.

In the 3.x branch, the situation with `arch` and `bits` is very brittle,
so we only add the explicit `arch` argument for the arm32/arm64 builds.
x86_32 still relies on `bits=32`.

This would all be worth refactoring upstream like we did for 4.0, but
it's a major undertaking and breaking change, which I'd prefer to avoid
in 3.6.

For Linux builds, we move the `strip` calls to the link stage, as this
needs to be done with the arch-appropriate `strip` binary, so it's easier
done there. In `master`, we now let the compiler strip automatically
during the build if no debug symbols are requested, but this change
wasn't backported to 3.x.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants