Skip to content

[Backport] Fix issues/pr list broken when there are many repositories (#8409) #8418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 8, 2019
Merged

[Backport] Fix issues/pr list broken when there are many repositories (#8409) #8418

merged 2 commits into from
Oct 8, 2019

Conversation

6543
Copy link
Member

@6543 6543 commented Oct 8, 2019

Backport of #8409

@lunny @6543
Fix issues/pr list broken when there are many repositories (go-gitea#…
024e0d6 
…8409)

* fix issues/pr list broken when there are many repositories

* remove unused codes

* fix counting error on issues/prs

* keep the old logic

* fix panic

* fix tests
@lunny lunny added this to the 1.9.4 milestone Oct 8, 2019
@lunny lunny added the type/bug label Oct 8, 2019
@guillep2k
Copy link
Member

@lunny the version of xorm is OK for this?

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 8, 2019
@6543
Copy link
Member Author

6543 commented Oct 8, 2019 

routers/user/home.go:20:2: imported and not used: "github.com/Unknwon/com"
make: *** [Makefile:311: gitea] Fehler 2

@lunny
Copy link
Member

lunny commented Oct 8, 2019

@guillep2k Only SetExpr with Where is a new feature of recent xorm but this PR has no that usecase. release/v1.9 use builder v0.3.5 which supports In with subquery, https://gitea.com/xorm/builder/src/tag/v0.3.5/cond_in.go#L189 .
But I will wait until a new try instance upgrade before merge this.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 8, 2019
@6543 6543 mentioned this pull request Oct 8, 2019
Merged
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 8, 2019
@lunny lunny added the status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR label Oct 8, 2019
@lafriks lafriks merged commit 0ea4b78 into go-gitea:release/v1.9 Oct 8, 2019
lafriks added a commit that referenced this pull request Oct 8, 2019
@lafriks
Revert "[Backport] Fix issues/pr list broken when there are many repo…
ab81e44 
…sitories (#8409) (#8418)"

This reverts commit 0ea4b78.
@lafriks lafriks mentioned this pull request Oct 8, 2019
Merged
@lafriks
Copy link
Member

lafriks commented Oct 8, 2019

sh*#, did not see blocked label :/

@6543 6543 deleted the backports_8409 branch October 10, 2019 02:14
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

+1 more reviewer

@guillep2k guillep2k guillep2k approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR type/bug
Projects
None yet
Milestone
1.9.4
Development

Successfully merging this pull request may close these issues.
6 participants
@6543 @guillep2k @lunny @lafriks @techknowlogick @GiteaBot