Skip to content

Fix issues/pr list broken when there are many repositories #8409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 8, 2019
Merged

Fix issues/pr list broken when there are many repositories #8409

merged 7 commits into from
Oct 8, 2019

Conversation

lunny
Copy link
Member

@lunny lunny commented Oct 7, 2019 •
edited
Loading

Fix #7750

This PR adds a new repositories sub query as condition instead of list all repository ids.

@lunny lunny added this to the 1.10.0 milestone Oct 7, 2019
guillep2k
guillep2k suggested changes Oct 7, 2019
View reviewed changes
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 7, 2019
@lunny lunny force-pushed the lunny/fix_issues_bug branch from 388143e to 209f76e Compare October 7, 2019 05:59
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 7, 2019
@guillep2k
Copy link
Member

Sorry, I've missed that when reviewing.

guillep2k
guillep2k reviewed Oct 7, 2019
View reviewed changes
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 8, 2019
@codecov-io
Copy link

Codecov Report

Merging #8409 into master will increase coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8409      +/-   ##
==========================================
+ Coverage   41.81%   41.81%   +<.01%     
==========================================
  Files         497      497              
  Lines       65611    65571      -40     
==========================================
- Hits        27432    27417      -15     
+ Misses      34664    34642      -22     
+ Partials     3515     3512       -3
Impacted Files Coverage Δ
models/issue.go 51% <100%> (+0.29%) ⬆️
models/user.go 48.82% <28.57%> (-1.36%) ⬇️
routers/user/home.go 56.65% <46.66%> (+3.49%) ⬆️
modules/avatar/avatar.go 48% <0%> (-6%) ⬇️
modules/log/event.go 64.61% <0%> (-1.03%) ⬇️
models/repo_list.go 72.19% <0%> (-0.98%) ⬇️
models/repo_indexer.go 70.15% <0%> (+3.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a269f7...22f60fc. Read the comment docs.

@lunny lunny merged commit 78438d3 into go-gitea:master Oct 8, 2019
6543 pushed a commit to 6543-forks/gitea that referenced this pull request Oct 8, 2019
@lunny @6543
Fix issues/pr list broken when there are many repositories (go-gitea#…
024e0d6 
…8409)

* fix issues/pr list broken when there are many repositories

* remove unused codes

* fix counting error on issues/prs

* keep the old logic

* fix panic

* fix tests
@6543 6543 mentioned this pull request Oct 8, 2019
Merged
lafriks pushed a commit that referenced this pull request Oct 8, 2019
@6543 @lafriks
[Backport] Fix issues/pr list broken when there are many repositories (…
0ea4b78 
…#8409) (#8418)

* Fix issues/pr list broken when there are many repositories (#8409)

* fix issues/pr list broken when there are many repositories

* remove unused codes

* fix counting error on issues/prs

* keep the old logic

* fix panic

* fix tests

* rm unused import
lafriks added a commit that referenced this pull request Oct 8, 2019
@lafriks
Revert "[Backport] Fix issues/pr list broken when there are many repo…
ab81e44 
…sitories (#8409) (#8418)"

This reverts commit 0ea4b78.
@lunny lunny deleted the lunny/fix_issues_bug branch October 8, 2019 15:34
lunny added a commit that referenced this pull request Oct 8, 2019
@lunny
Revert "Fix issues/pr list broken when there are many repositories (#…
51e9225 
…8409)"

This reverts commit 78438d3.
@lunny lunny mentioned this pull request Oct 8, 2019
Merged
lafriks pushed a commit that referenced this pull request Oct 8, 2019
@lunny @lafriks
Revert "Fix issues/pr list broken when there are many repositories (#…
170743c 
…8409)" (#8427)

This reverts commit 78438d3.
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@6543 6543 6543 approved these changes

+1 more reviewer

@guillep2k guillep2k guillep2k approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.10.0
Development

Successfully merging this pull request may close these issues.

Error 500 when visit /issues and /pulls (too many SQL variables)
6 participants
@lunny @guillep2k @codecov-io @techknowlogick @6543 @GiteaBot