Instance signing rule pubkey should allow all public keys, not just GPG

[lyricwulf]

Instance signing rule pubkey is described as "Only sign if the user has a public key", however if the user only has SSH public keys, this check will fail, as it only checks for GPG keys.

Changed the pubkey checks to call a helper userHasPubkeys which sequentially checks for GPG, then SSH keys.

Related #34341

[wxiaoguang]

Is it right? (Update: see below) Any user can have a public key for SSH access (but not signing), so all user passes the check?

[lyricwulf]

Is it right? Any user can have a public key for SSH access (but not signing), so all user passes the check?

Isn't it right? You use it in combination with "commitssigned" or "headsigned" to check if the user did sign it.

It is entirely possible I don't understand the intent behind the configuration, but I assumed from the code (being "pubkey" and not "gpgkey") and the documentation page (users with a public key) that users who sign with SSH should be able to use instance SSH signing. 😅

[wxiaoguang]

Hmm, you are right, the configuration option looks strange, anyone who added a GPG pubkey or SSH pubkey (without verification) can pass the check, so no idea whether it really verifies anything useful (that's why I don't know whether it is right in firs time)

---

Since the "pubkey" is designed to work that way, so it's fine to add the SSH check.

Is it possible to add a test to cover userHasPubkeys logic?

[lyricwulf]

Hmm, you are right, the configuration option looks strange, anyone who added a GPG pubkey or SSH pubkey (without verification) can pass the check, so no idea whether it really verifies anything useful (that's why I don't know whether it is right in firs time)

Yes I'm not sure of the effect. It does seem extremely lenient, but at least this way it is consistently extremely lenient 😆

Is it possible to add a test to cover userHasPubkeys logic?

Added a unit test 🙂