-
-
Notifications
You must be signed in to change notification settings - Fork 6k
when sorting issues by nearest due date, issues without due date should be sorted ascending #35267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I could have a conflict of interest reviewing this - might you wana review it instead ? - thx :) |
I think the root problem is here: #35200 (comment) If this PR is the the same problem as the abused "deadline_unix" field, then it needs a complete fix, but not patch it. |
We noticed the abuse of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I see, you are absolutely right. It makes sense:
- nearduedate: Asc("issue.created_unix")
- farduedate: Desc("issue.created_unix")
* main: (34 commits) when sorting issues by nearest due date, issues without due date should be sorted ascending (go-gitea#35267) [skip ci] Updated translations via Crowdin Upgrade xz to v0.5.15 (go-gitea#35377) Refactor db package (go-gitea#35380) Remove the duplicated function GetTags (go-gitea#35375) [skip ci] Updated translations via Crowdin Allow foreachref parser to grow its buffer (go-gitea#35365) Remove global context from db package (go-gitea#35371) Use gitrepo.SetDefaultBranch when set default branch of wiki repository (go-gitea#33911) Deleting branch could delete broken branch which has database record but git branch is missing (go-gitea#35360) Remove incorrect "db.DefaultContext" usages (go-gitea#35366) Refactor to use reflect.TypeFor (go-gitea#35370) [skip ci] Updated translations via Crowdin Remove wrong "git.DefaultContext" (go-gitea#35364) Fix context usages (go-gitea#35348) Instance signing rule `pubkey` should allow all public keys, not just GPG (go-gitea#35357) Allow deleting comment with content via API like web did (go-gitea#35346) Prevent duplicate actions email (go-gitea#35215) rename nightly docker tag for main branch (go-gitea#35344) Fix atom/rss mixed error (go-gitea#35345) ... # Conflicts: # tests/integration/pull_merge_test.go
* giteaofficial/main: [skip ci] Updated translations via Crowdin when sorting issues by nearest due date, issues without due date should be sorted ascending (go-gitea#35267) [skip ci] Updated translations via Crowdin Upgrade xz to v0.5.15 (go-gitea#35377) Refactor db package (go-gitea#35380) Remove the duplicated function GetTags (go-gitea#35375) [skip ci] Updated translations via Crowdin Allow foreachref parser to grow its buffer (go-gitea#35365) Remove global context from db package (go-gitea#35371) Use gitrepo.SetDefaultBranch when set default branch of wiki repository (go-gitea#33911) Deleting branch could delete broken branch which has database record but git branch is missing (go-gitea#35360)
When sorting issues and pull requests by the nearest due date, the issues and PRs without a due date are currently sorted descending by their creation date. This seems counter intuitive to me. When sorting by nearest due date I want to see the issues/PRs in the order they should be worked on. For issues/PRs without a due date that order should be first come first served rather than last come first served.
This PR now changes the ordering of issues/PRs which don't have a due date to ascending by their creation date. So that the oldest is shown first and the newest last.
This now also makes the sort order nearest due date a true opposite to farthest due date. At farthest due date the newest is shown first and the oldest last.
Sponsored by Kithara Software GmbH