Check IsActionsToken for LFS authentication
#23841
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yp05327
reviewed
Mar 31, 2023
GiteaBot
added
the
lgtm/need 2
yp05327
reviewed
Mar 31, 2023
yp05327
reviewed
Mar 31, 2023
|
It follows the logic in gitea/routers/web/repo/http.go Line 198 in 1bc4ffc |
wolfogre
approved these changes
Mar 31, 2023
GiteaBot
added
lgtm/need 1
lunny
requested changes
Apr 1, 2023
lunny
added
the
outdated/backport/v1.19
lunny
added
the
skip-changelog
Codecov Report
@@ Coverage Diff @@
## main #23841 +/- ##
==========================================
- Coverage 47.14% 47.00% -0.14%
==========================================
Files 1149 1158 +9
Lines 151446 153211 +1765
==========================================
+ Hits 71397 72019 +622
- Misses 71611 72693 +1082
- Partials 8438 8499 +61
... and 75 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
lunny
approved these changes
Apr 1, 2023
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Apr 2, 2023
Close go-gitea#23824 Actions cannot fetch LFS objects from private repos because we don't check if the user is the `ActionUser`.
wolfogre
removed
the
reviewed/wait-merge
zeripath
pushed a commit
that referenced
this pull request
Apr 2, 2023
Backport #23841 by @Zettat123 Close #23824 Actions cannot fetch LFS objects from private repos because we don't check if the user is the `ActionUser`. Co-authored-by: Zettat123 <[email protected]>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Apr 3, 2023
* upstream/main: [skip ci] Updated translations via Crowdin Update JS deps (go-gitea#23853) Added close/open button to details page of milestone (go-gitea#23877) Check `IsActionsToken` for LFS authentication (go-gitea#23841) Prefill input values in oauth settings as intended (go-gitea#23829) Display image size for multiarch container images (go-gitea#23821) Use clippie module to copy to clipboard (go-gitea#23801) Remove assertion debug code for show/hide refactoring (go-gitea#23576) [skip ci] Updated translations via Crowdin Remove jQuery ready usage (go-gitea#23858) Fix JS error when changing PR's target branch (go-gitea#23862) Improve action log display with control chars (go-gitea#23820) Fix review conversation reply (go-gitea#23846) Improve home page template, fix Sort dropdown menu flash (go-gitea#23856) Make first section on home page full width (go-gitea#23854) [skip ci] Updated translations via Crowdin Fix incorrect CORS failure detection logic (go-gitea#23844)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #23824
Actions cannot fetch LFS objects from private repos because we don't check if the user is the
ActionUser.