Skip to content

Prefill input values in oauth settings as intended #23829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 2, 2023
Merged

Prefill input values in oauth settings as intended #23829

merged 4 commits into from
Apr 2, 2023

Conversation

yp05327
Copy link
Contributor

@yp05327 yp05327 commented Mar 31, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Mar 31, 2023 •
edited
Loading

Codecov Report

Merging #23829 (a3f5205) into main (f521e88) will decrease coverage by 0.13%.
The diff coverage is 28.82%.

❗ Current head a3f5205 differs from pull request most recent head bdac1a4. Consider uploading reports for the commit bdac1a4 to get more accurate results

@@            Coverage Diff             @@
##             main   #23829      +/-   ##
==========================================
- Coverage   47.14%   47.01%   -0.13%     
==========================================
  Files        1149     1158       +9     
  Lines      151446   153179    +1733     
==========================================
+ Hits        71397    72023     +626     
- Misses      71611    72654    +1043     
- Partials     8438     8502      +64
Impacted Files Coverage Δ
cmd/dump.go 0.66% <0.00%> (-0.01%) ⬇️
cmd/mailer.go 0.00% <0.00%> (ø)
cmd/manager.go 0.00% <0.00%> (ø)
cmd/manager_logging.go 0.00% <0.00%> (ø)
cmd/migrate_storage.go 5.76% <0.00%> (-0.12%) ⬇️
cmd/restore_repo.go 0.00% <0.00%> (ø)
cmd/web.go 0.00% <0.00%> (ø)
models/actions/run.go 1.63% <0.00%> (-0.10%) ⬇️
models/actions/runner.go 1.44% <ø> (ø)
models/packages/package.go 45.45% <0.00%> (-1.13%) ⬇️
... and 64 more

... and 67 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 31, 2023
@yp05327
Copy link
Contributor Author

yp05327 commented Mar 31, 2023

It seems that AuthenticationForm.TLS is not used.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 31, 2023
@techknowlogick techknowlogick added type/bug topic/ui Change the appearance of the Gitea UI labels Mar 31, 2023
@techknowlogick techknowlogick added this to the 1.20.0 milestone Mar 31, 2023
@techknowlogick techknowlogick added the outdated/backport/v1.19 This PR should be backported to Gitea 1.19 label Mar 31, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 1, 2023
@delvh delvh changed the title Fix incorrect value in oauth template Prefill input values in oauth template as intended Apr 1, 2023
@delvh delvh changed the title Prefill input values in oauth template as intended Prefill input values in oauth settings as intended Apr 1, 2023
@delvh delvh added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 1, 2023
@lunny lunny merged commit 0ed62db into go-gitea:main Apr 2, 2023
@lunny lunny removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 2, 2023
@GiteaBot GiteaBot mentioned this pull request Apr 2, 2023
Merged
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Apr 2, 2023
@yp05327
Prefill input values in oauth settings as intended (go-gitea#23829)
a4123fa
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label Apr 2, 2023
zjjhot added a commit to zjjhot/gitea that referenced this pull request Apr 3, 2023
@zjjhot
Merge remote-tracking branch 'upstream/main'
a6741d8 
* upstream/main:
  [skip ci] Updated translations via Crowdin
  Update JS deps (go-gitea#23853)
  Added close/open button to details page of milestone (go-gitea#23877)
  Check `IsActionsToken` for LFS authentication (go-gitea#23841)
  Prefill input values in oauth settings as intended (go-gitea#23829)
  Display image size for multiarch container images (go-gitea#23821)
  Use clippie module to copy to clipboard (go-gitea#23801)
  Remove assertion debug code for show/hide refactoring (go-gitea#23576)
  [skip ci] Updated translations via Crowdin
  Remove jQuery ready usage (go-gitea#23858)
  Fix JS error when changing PR's target branch (go-gitea#23862)
  Improve action log display with control chars (go-gitea#23820)
  Fix review conversation reply (go-gitea#23846)
  Improve home page template, fix Sort dropdown menu flash (go-gitea#23856)
  Make first section on home page full width (go-gitea#23854)
  [skip ci] Updated translations via Crowdin
  Fix incorrect CORS failure detection logic (go-gitea#23844)
6543 pushed a commit that referenced this pull request Apr 3, 2023
@GiteaBot @yp05327
Prefill input values in oauth settings as intended (#23829) (#23871)
c68650a 
Backport #23829 by @yp05327

Co-authored-by: yp05327 <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. outdated/backport/v1.19 This PR should be backported to Gitea 1.19 topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
1.20.0
Development

Successfully merging this pull request may close these issues.
7 participants
@yp05327 @codecov-commenter @silverwind @delvh @lunny @techknowlogick @GiteaBot