Dont overwrite err with nil & rename PullCheckingFuncs to reflect there usage #19572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since there will be more queues related to pulls, use a meaningfull name
6543
added
the
type/refactoring
6543
changed the title
delvh
approved these changes
May 1, 2022
GiteaBot
added
the
lgtm/need 1
|
as per commit message: |
6543
changed the title
GiteaBot
added
lgtm/done
6543
changed the title
delvh
reviewed
May 1, 2022
6543
added a commit
to 6543-forks/gitea
that referenced
this pull request
May 1, 2022
Co-authored-by: delvh <[email protected]>
delvh
approved these changes
May 1, 2022
6543
added a commit
that referenced
this pull request
May 1, 2022
* Dont overwrite err with nil (part #19572) Co-authored-by: Gusted <[email protected]>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
May 3, 2022
* giteaofficial/main: Fix some slice problems (incorrect slice length) (go-gitea#19592) Fix sending empty notifications (go-gitea#19589) Handle the error of a missing blob object fix go-gitea#19530 (go-gitea#19552) Remove legacy `+build:` constraint (go-gitea#19582) Federation: return useful statistic information for nodeinfo (go-gitea#19561) Upgrade required git version to 2.0 (go-gitea#19577) add smtp password to install page (go-gitea#17564) ignore DNS error when doing migration allow/block check (go-gitea#19566) [skip ci] Updated translations via Crowdin Dont overwrite err with nil & rename PullCheckingFuncs to reflect there usage (go-gitea#19572) Improve UI on mobile (go-gitea#19546) Add API to check if team has repo access (go-gitea#19540)
19 tasks
AbdulrhmnGhanem
pushed a commit
to kitspace/gitea
that referenced
this pull request
Aug 24, 2022
…re usage (go-gitea#19572) - dont overwrite err with nil unintentionaly - rename CheckPRReadyToMerge to CheckPullBranchProtections - rename prQueue to prPatchCheckerQueue from go-gitea#9307 Co-authored-by: delvh <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from #9307