Skip to content

Ignore DNS error when doing migration allow/block check #19566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 2, 2022
Merged

Ignore DNS error when doing migration allow/block check #19566

merged 5 commits into from
May 2, 2022

Conversation

wxiaoguang
Copy link
Contributor

As the title & comment.

Try to fix #19565

@wxiaoguang wxiaoguang added this to the 1.17.0 milestone Apr 30, 2022
@wxiaoguang wxiaoguang mentioned this pull request Apr 30, 2022
Merged
@wxiaoguang wxiaoguang added topic/repo-migration Migrate repos from other platforms to Gitea, or from Gitea to them backport/done All backports for this PR have been created backport/v1.16 labels Apr 30, 2022
@wxiaoguang wxiaoguang mentioned this pull request Apr 30, 2022
Closed
lunny
lunny reviewed Apr 30, 2022
View reviewed changes
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 30, 2022
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 1, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #19566 (a8f061f) into main (3725fa2) will increase coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head a8f061f differs from pull request most recent head c28ff2d. Consider uploading reports for the commit c28ff2d to get more accurate results

@@            Coverage Diff             @@
##             main   #19566      +/-   ##
==========================================
+ Coverage   47.39%   47.42%   +0.03%     
==========================================
  Files         952      952              
  Lines      132620   132615       -5     
==========================================
+ Hits        62858    62899      +41     
+ Misses      62185    62145      -40     
+ Partials     7577     7571       -6
Impacted Files Coverage Δ
models/error.go 36.76% <ø> (+0.30%) ⬆️
services/migrations/migrate.go 49.10% <100.00%> (+0.58%) ⬆️
services/migrations/gitlab.go 0.81% <0.00%> (-4.50%) ⬇️
modules/git/repo_base_nogogit.go 70.58% <0.00%> (-3.93%) ⬇️
modules/git/utils.go 66.29% <0.00%> (-3.38%) ⬇️
services/migrations/gitea_uploader.go 56.30% <0.00%> (-1.36%) ⬇️
models/repo_list.go 75.66% <0.00%> (-0.49%) ⬇️
services/pull/pull.go 39.90% <0.00%> (-0.16%) ⬇️
models/issue_comment.go 52.26% <0.00%> (-0.12%) ⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8905cb...c28ff2d. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 2, 2022
@lunny lunny merged commit 71bafa0 into go-gitea:main May 2, 2022
@wxiaoguang wxiaoguang deleted the fix-migration-dns-error branch May 2, 2022 04:13
zjjhot added a commit to zjjhot/gitea that referenced this pull request May 3, 2022
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
94f1981 
* giteaofficial/main:
  Fix some slice problems (incorrect slice length) (go-gitea#19592)
  Fix sending empty notifications (go-gitea#19589)
  Handle the error of a missing blob object fix go-gitea#19530 (go-gitea#19552)
  Remove legacy `+build:` constraint (go-gitea#19582)
  Federation: return useful statistic information for nodeinfo (go-gitea#19561)
  Upgrade required git version to 2.0 (go-gitea#19577)
  add smtp password to install page (go-gitea#17564)
  ignore DNS error when doing migration allow/block check (go-gitea#19566)
  [skip ci] Updated translations via Crowdin
  Dont overwrite err with nil & rename PullCheckingFuncs to reflect there usage (go-gitea#19572)
  Improve UI on mobile (go-gitea#19546)
  Add API to check if team has repo access (go-gitea#19540)
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 24, 2022
@wxiaoguang @6543 @AbdulrhmnGhanem
ignore DNS error when doing migration allow/block check (go-gitea#19566)
7b8266c 
Co-authored-by: 6543 <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/repo-migration Migrate repos from other platforms to Gitea, or from Gitea to them type/bug
Projects
None yet
Milestone
1.17.0
Development

Successfully merging this pull request may close these issues.

Migration from behind proxy fails
5 participants
@wxiaoguang @codecov-commenter @lunny @6543 @GiteaBot