Skip to content

Fix lfs preview bug (#14428) #14433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 23, 2021
Merged

Fix lfs preview bug (#14428) #14433

merged 2 commits into from
Jan 23, 2021

Conversation

6543
Copy link
Member

@6543 6543 commented Jan 22, 2021

Backport #14428

@6543 6543 added the type/bug label Jan 22, 2021
@6543 6543 added this to the 1.13.2 milestone Jan 22, 2021
@6543 6543 mentioned this pull request Jan 22, 2021
Merged
@zeripath
Copy link
Contributor

Are you sure that this needs a backport? 1.13 just has GoGit.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 22, 2021
@6543
Copy link
Member Author

6543 commented Jan 22, 2021

@zeripath I dont think it has to do with NoGoGit ... since code aroud this is ~2years old ... and your change didn't cange modules/lfs/pointers.go (lfs.ReadMetaObject) ...

@6543
Copy link
Member Author

6543 commented Jan 22, 2021

@zeripath -> https://github.com/go-gitea/gitea/blame/master/modules/lfs/pointers.go#L68

@zeripath
Copy link
Contributor

zeripath commented Jan 22, 2021 •
edited
Loading

ah it's due to the storage changes.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 22, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 23, 2021
@6543 6543 merged commit dd827d6 into go-gitea:release/v1.13 Jan 23, 2021
@6543 6543 deleted the backport_14428 branch January 23, 2021 02:55
@go-gitea go-gitea locked and limited conversation to collaborators Mar 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

+1 more reviewer

@zeripath zeripath zeripath approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.13.2
Development

Successfully merging this pull request may close these issues.
4 participants
@6543 @zeripath @lunny @GiteaBot