Skip to content

Fix lfs preview bug #14428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 22, 2021
Merged

Fix lfs preview bug #14428

merged 1 commit into from
Jan 22, 2021

Conversation

lunny
Copy link
Member

@lunny lunny commented Jan 22, 2021

Fix #14426

@lunny lunny added this to the 1.14.0 milestone Jan 22, 2021
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 22, 2021
@codecov-io
Copy link

Codecov Report

Merging #14428 (f3a9466) into master (61f9a72) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14428      +/-   ##
==========================================
- Coverage   41.78%   41.76%   -0.02%     
==========================================
  Files         748      748              
  Lines       80103    80103              
==========================================
- Hits        33470    33457      -13     
- Misses      41112    41124      +12     
- Partials     5521     5522       +1
Impacted Files Coverage Δ
routers/repo/view.go 41.58% <0.00%> (ø)
modules/git/repo_base_nogogit.go 63.63% <0.00%> (-9.10%) ⬇️
modules/charset/charset.go 68.53% <0.00%> (-6.75%) ⬇️
modules/git/utils.go 77.77% <0.00%> (-2.78%) ⬇️
services/gitdiff/gitdiff.go 68.99% <0.00%> (-1.94%) ⬇️
models/gpg_key.go 53.33% <0.00%> (-0.58%) ⬇️
services/pull/pull.go 42.64% <0.00%> (+0.49%) ⬆️
models/repo_list.go 78.76% <0.00%> (+0.88%) ⬆️
modules/log/file.go 75.20% <0.00%> (+1.60%) ⬆️
modules/util/timer.go 85.71% <0.00%> (+42.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e35d1bf...f3a9466. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 22, 2021
@zeripath zeripath merged commit 3287ce2 into go-gitea:master Jan 22, 2021
@zeripath
Copy link
Contributor

this is probably a regression due to no-go-git

6543 pushed a commit to 6543-forks/gitea that referenced this pull request Jan 22, 2021
@lunny @6543
Fix lfs preview bug (go-gitea#14428)
0a91655
@6543 6543 mentioned this pull request Jan 22, 2021
Merged
@6543
Copy link
Member

6543 commented Jan 22, 2021

backport: #14433

@6543 6543 added the backport/done All backports for this PR have been created label Jan 22, 2021
@lunny lunny deleted the lunny/fix_lfs_preview branch January 23, 2021 02:09
6543 added a commit that referenced this pull request Jan 23, 2021
@6543 @lunny
Fix lfs preview bug (#14428) (#14433)
dd827d6 
Co-authored-by: Lunny Xiao <[email protected]>
a1012112796 added a commit to a1012112796/gitea that referenced this pull request Jan 25, 2021
@a1012112796
Merge branch 'master' into feature/dismissing_reviews
c599356 
* master: (358 commits)
  [skip ci] Updated translations via Crowdin
  Use caddy's certmagic library for extensible/robust ACME handling (go-gitea#14177)
  Redirect on changed user and org name (go-gitea#11649)
  chore: bump minio to RELEASE.2021-01-16T02-19-44Z (go-gitea#14445)
  [skip ci] Updated translations via Crowdin
  CI: skip build steps for cron update works (go-gitea#14443)
  [skip ci] Updated licenses and gitignores
  [skip ci] Updated translations via Crowdin
  just overload to not get it by mistake again ... (go-gitea#14440)
  [skip ci] Updated translations via Crowdin
  Add link to packages in openSUSE build service (go-gitea#14439)
  Improve Description in new/ edit Project template (go-gitea#14429)
  Don't show "Reference in new issue" when issues unit is globally disabled (go-gitea#14437)
  CI: Update license & gitignore by cron (go-gitea#14419)
  Fix close/reopen with comment (go-gitea#14436)
  Add german translation guidelines (go-gitea#14283)
  [skip ci] Updated translations via Crowdin
  Fix lfs preview bug (go-gitea#14428)
  [skip ci] Updated translations via Crowdin
  Bump gsap from 3.5.1 to 3.6.0 (go-gitea#14410)
  ...
a1012112796 added a commit to a1012112796/gitea that referenced this pull request Jan 25, 2021
@a1012112796
Merge branch 'master' into empty_pr
7863e53 
* master: (542 commits)
  [skip ci] Updated translations via Crowdin
  Use caddy's certmagic library for extensible/robust ACME handling (go-gitea#14177)
  Redirect on changed user and org name (go-gitea#11649)
  chore: bump minio to RELEASE.2021-01-16T02-19-44Z (go-gitea#14445)
  [skip ci] Updated translations via Crowdin
  CI: skip build steps for cron update works (go-gitea#14443)
  [skip ci] Updated licenses and gitignores
  [skip ci] Updated translations via Crowdin
  just overload to not get it by mistake again ... (go-gitea#14440)
  [skip ci] Updated translations via Crowdin
  Add link to packages in openSUSE build service (go-gitea#14439)
  Improve Description in new/ edit Project template (go-gitea#14429)
  Don't show "Reference in new issue" when issues unit is globally disabled (go-gitea#14437)
  CI: Update license & gitignore by cron (go-gitea#14419)
  Fix close/reopen with comment (go-gitea#14436)
  Add german translation guidelines (go-gitea#14283)
  [skip ci] Updated translations via Crowdin
  Fix lfs preview bug (go-gitea#14428)
  [skip ci] Updated translations via Crowdin
  Bump gsap from 3.5.1 to 3.6.0 (go-gitea#14410)
  ...
@go-gitea go-gitea locked and limited conversation to collaborators Mar 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@6543 6543 6543 approved these changes

+2 more reviewers

@zeripath zeripath zeripath approved these changes

@a1012112796 a1012112796 a1012112796 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.

Error 500 when trying to open LFS files stored on S3 in the WebUI
6 participants
@lunny @codecov-io @zeripath @6543 @a1012112796 @GiteaBot