Fix buttons left-margin #11427
Merged
Fix buttons left-margin #11427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One thing I've noticed is that somewhere along the line we decided to make .left and .right mean that we wanted stuff floated left and right. This breaks fomantics (and semantics) ideas - they should have been .floated.left and .floated.right but meh... (in fact we should only be using fomantics ui-semantic class names whilst mocking up and then have our less files use them perhaps as mixins with true semantic class names and ids.) |
GiteaBot
added
the
lgtm/need 2
zeripath
approved these changes
May 16, 2020
GiteaBot
added
lgtm/need 1
mrsdizzie
approved these changes
May 16, 2020
GiteaBot
added
lgtm/done
lafriks
approved these changes
May 16, 2020
lafriks
added
the
skip-changelog
ydelafollye
pushed a commit
to ydelafollye/gitea
that referenced
this pull request
Jul 31, 2020
Co-authored-by: Lauris BH <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced by #11139
Fixes this:
