Prettify timeline 3 #11139
Merged
Prettify timeline 3 #11139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #11139 +/- ##
==========================================
- Coverage 43.84% 43.83% -0.01%
==========================================
Files 607 607
Lines 86893 86893
==========================================
- Hits 38098 38090 -8
- Misses 44093 44099 +6
- Partials 4702 4704 +2
Continue to review full report at Codecov.
|
GiteaBot
added
the
lgtm/need 2
lafriks
reviewed
Apr 19, 2020
silverwind
approved these changes
Apr 20, 2020
GiteaBot
added
lgtm/need 1
6543
approved these changes
Apr 22, 2020
GiteaBot
added
lgtm/done
|
Is this still a draft? |
|
a draft with lgtm 😆 - @Sorien ☝️ |
|
I wanted to try if it's possible to align buttons by switching margin from right to left, I will try to look at it tomorrow. |
Sorien
force-pushed
the
prettify-timeline-3
branch
from
1933fee to
84e3ddb
Compare
|
ok should be ready, rebased commits (sorry for that), new commits from |
|
I have a question why there is file dropzone area in the preview tab? |
guillep2k
added
lgtm/need 2
|
@Sorien lint fails. |
GiteaBot
added
lgtm/done
6543
approved these changes
May 4, 2020
|
@silverwind Care to take another look? |
silverwind
approved these changes
May 14, 2020
Not sure what you mean but I'd say a dropzone should be outside the write/preview tabs. |
techknowlogick
added
the
skip-changelog
This was referenced May 15, 2020
ydelafollye
pushed a commit
to ydelafollye/gitea
that referenced
this pull request
Jul 31, 2020
* Fix timeline comments sections borders * Fix files dropzone right alignment * Update review comment form and controls * Clear segment style from comment form tabs * Remove segment class from pulls tab * Fix Time Tracker - Add Time button border * Fix buttons right alignment * Markdown tab minimal height * Fix DropZone hover effect * Fix Lint + remove unused controls class Co-authored-by: Lunny Xiao <[email protected]> Co-authored-by: zeripath <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix timeline comments last section borders
Fix DropZone and buttons left alignment
Update review comment form to look the same as others
Fix Time Tracker Add Time button left border
Remove/Tidy up some classes