Remove protocol 1 and 2 #2
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The BoltKitTests depends on the TeamCity environment with the new test environment be running to not be skipped, so it should be moved to the integration tests phase avoiding being always skipped during the unit tests phase. Rename it to `BoltKitIT` does this job.
This change introduces a testing component that allows for tests to be written once in a central repo (https://github.com/neo4j-drivers/testkit) and then executed for each driver. The build produces an executable server that acts as the intermediatory with TestKit. Co-authored-by: Peter Wilhelmsson <[email protected]>
America/Santiago can cause issues on windows, see: https://stackoverflow.com/questions/37533796/java-calendar-returns-wrong-hour-in-ms-windows-for-america-santiago-zone
Adds the ability for TrustStategy to configure whether or not certificate revocation checking is to be carried out. By default revocation checking is disabled. If enabled the driver will check the validity of stapled OCSP (Online Certificate Status Protocol) response(s). These responses are returned during the TLS handshake by the server and if not present, the driver will fail to accept the certificate. See: https://tools.ietf.org/html/rfc6961
bigmontz
force-pushed
the
remove-protocol-1-and-2
branch
from
9e21647 to
525590f
Compare
The reference this protocols are not needed since it's not used by the driver anymore. During the remotion of these protocol version, the tests were refactoried to be specific per version instead of assume the re-use done on the protocols implementation.
bigmontz
force-pushed
the
remove-protocol-1-and-2
branch
from
525590f to
7f82e7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.