Skip to content

Rename tests end with BoltKitTest to BoltKitIT #760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 17, 2020
Merged

Rename tests end with BoltKitTest to BoltKitIT #760

merged 1 commit into from
Sep 17, 2020

Conversation

@bigmontz
Copy link
Contributor

@bigmontz bigmontz commented Sep 10, 2020 •
edited
Loading

The BoltKitTests depends on the TeamCity environment with the new test environment be running to not be skipped,
so it should be moved to the integration tests phase avoiding being always skipped during the unit tests phase.

Rename it with the suffix BoltKitIT does this job.

@bigmontz bigmontz force-pushed the fix/tests_segregation branch 2 times, most recently from 6ce1f6d to 5662c0f Compare September 10, 2020 12:38
@bigmontz bigmontz marked this pull request as ready for review September 10, 2020 12:45
michael-simons
michael-simons approved these changes Sep 10, 2020
View reviewed changes
Copy link
Contributor

@michael-simons michael-simons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I guess you needed to explicitly include the *IT.java and *ITCase.java because one entry would overwrite all the others, right?

@bigmontz
Copy link
Contributor Author

bigmontz commented Sep 10, 2020

LGTM. I guess you needed to explicitly include the *IT.java and *ITCase.java because one entry would overwrite all the others, right?

Exactly

@2hdddg
Copy link

2hdddg commented Sep 10, 2020

Would it be a bigger but more safe change to append IT to the boltkit tests?
We need to be sure that we dont lose any tests in the process (the test count in Teamcity can be used to verifiy)

@bigmontz
Copy link
Contributor Author

bigmontz commented Sep 10, 2020

Would it be a bigger but more safe change to append IT to the boltkit tests?
We need to be sure that we dont lose any tests in the process (the test count in Teamcity can be used to verifiy)

I could named BoltKitIT instead of BoltKitTest. I also get a bit more explicit the intention in the code.

@bigmontz
Rename tests end with BoltKitTest to the BoltKitIT
5d33b2f 
The BoltKitTests depends on the TeamCity environment with the new test environment be running to not be skipped,
so it should be moved to the integration tests phase avoiding being always skipped during the unit tests phase.

Rename it to `BoltKitIT` does this job.
@bigmontz bigmontz force-pushed the fix/tests_segregation branch from 5662c0f to 5d33b2f Compare September 10, 2020 13:57
@bigmontz bigmontz changed the title Move tests end with BoltKitTest to the integration test phase Rename tests end with BoltKitTest to BoltKitIT Sep 10, 2020
@gjmwoods gjmwoods merged commit 171a7e7 into neo4j:4.2 Sep 17, 2020
@bigmontz bigmontz deleted the fix/tests_segregation branch September 17, 2020 10:13
bigmontz added a commit to bigmontz/neo4j-java-driver that referenced this pull request Sep 25, 2020
@bigmontz
Rename tests end with BoltKitTest to the BoltKitIT (neo4j#760)
bf76e1d 
The BoltKitTests depends on the TeamCity environment with the new test environment be running to not be skipped,
so it should be moved to the integration tests phase avoiding being always skipped during the unit tests phase.

Rename it to `BoltKitIT` does this job.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michael-simons michael-simons michael-simons approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bigmontz @2hdddg @michael-simons @gjmwoods