-
Couldn't load subscription status.
- Fork 1.3k
Optionally consume Leeway from git #14567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2b0a7c7 to
c756e14
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need upgrade leeway version before we delete --dont-retag or only remove this flag when leeway-from-git is present? because without this flag, old version leeway will build failed or stuck in somewhere.
| gcloud auth configure-docker --quiet | ||
| export LEEWAY_WORKSPACE_ROOT=$(pwd) | ||
| leeway build -Dversion=latest -DimageRepoBase=eu.gcr.io/gitpod-core-dev/build components/ide/jetbrains/backend-plugin:latest --dont-retag | ||
| leeway build -Dversion=latest -DimageRepoBase=eu.gcr.io/gitpod-core-dev/build components/ide/jetbrains/backend-plugin:latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with current leeway version, if remove --dont-retag flag, it will build failed, so maybe we need update github action to use latest leeway from git
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't merge this until we cut a new release of Leeway and bump that everywhere. There are quite a few changes on Leeway main that isn't included in v0.3.1 and some of them are breaking, like the removal of --dont-retag
1cc2ab6 to
13e2dc3
Compare
|
/approve |
|
Here is the change that updates leeway in the dev-environment image #14631 |
Sice Leeway has been released & deployed here, I assume this PR can be merged now. |
Description
Optionally install leeway from git. This is helpful to test new versions of leeway before releasing them.
Related Issue(s)
Fixes #
How to test
werft run github -a leeway-from-git=truefrom CI to bypass job protection.Release Notes
Documentation
Werft options:
If enabled this will build
install/previewValid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh