remove no-longer-supported "--dont-retag" Leeway flag

Author: meysholdt

.github/workflows/jetbrains-update-backend-latest.yml

@@ -45,4 +45,4 @@ jobs:
       - run: |
           gcloud auth configure-docker --quiet
           export LEEWAY_WORKSPACE_ROOT=$(pwd)
-          leeway build -Dversion=latest -DimageRepoBase=eu.gcr.io/gitpod-core-dev/build components/ide/jetbrains/backend-plugin:latest --dont-retag
+          leeway build -Dversion=latest -DimageRepoBase=eu.gcr.io/gitpod-core-dev/build components/ide/jetbrains/backend-plugin:latest

.werft/jobs/build/build-and-publish.ts

@@ -16,7 +16,6 @@ export async function buildAndPublish(werft: Werft, jobConfig: JobConfig) {
     const {
         publishRelease,
         dontTest,
-        retag,
         version,
         localAppVersion,
         publishToNpm,
@@ -38,7 +37,7 @@ export async function buildAndPublish(werft: Werft, jobConfig: JobConfig) {
     exec(
         `leeway build --docker-build-options network=host --werft=true -c remote ${
             dontTest ? "--dont-test" : ""
-        } --dont-retag --coverage-output-path=${coverageOutput} --save /tmp/dev.tar.gz -Dversion=${version} -DimageRepoBase=eu.gcr.io/gitpod-core-dev/dev dev:all`,
+        } --coverage-output-path=${coverageOutput} --save /tmp/dev.tar.gz -Dversion=${version} -DimageRepoBase=eu.gcr.io/gitpod-core-dev/dev dev:all`,
     );
 
     if (publishRelease) {
@@ -61,7 +60,6 @@ export async function buildAndPublish(werft: Werft, jobConfig: JobConfig) {
         "--werft=true",
         "-c remote",
         dontTest ? "--dont-test" : "",
-        retag,
         `--coverage-output-path=${coverageOutput}`,
     ].filter((value) => value).join(" ");
 

.werft/jobs/build/job-config.ts

@@ -23,7 +23,6 @@ export interface JobConfig {
     publishToJBMarketplace: boolean;
     publishToNpm: string;
     publishToKots: boolean;
-    retag: string;
     replicatedChannel: string;
     storage: string;
     version: string;
@@ -98,7 +97,6 @@ export function jobConfig(werft: Werft, context: any): JobConfig {
     const publishToKots = "publish-to-kots" in buildConfig || withSelfHostedPreview || mainBuild;
 
     const localAppVersion = mainBuild || "with-localapp-version" in buildConfig ? version : "unknown";
-    const retag = "with-retag" in buildConfig ? "" : "--dont-retag";
     const cleanSlateDeployment = mainBuild || "with-clean-slate-deployment" in buildConfig;
     const installEELicense = !("without-ee-license" in buildConfig) || mainBuild;
     const withObservability = "with-observability" in buildConfig && !mainBuild;
@@ -165,7 +163,6 @@ export function jobConfig(werft: Werft, context: any): JobConfig {
         replicatedChannel,
         replicatedVersion,
         repository,
-        retag,
         storage,
         version,
         withContrib,

components/supervisor/hot-deploy.sh

@@ -19,7 +19,7 @@ echo "Image Version: $version"
 bldfn="/tmp/build-$version.tar.gz"
 
 docker ps &> /dev/null || (echo "You need a working Docker daemon. Maybe set DOCKER_HOST?"; exit 1)
-leeway build -Dversion="$version" -DimageRepoBase=eu.gcr.io/gitpod-core-dev/build .:docker --save "$bldfn" --dont-retag
+leeway build -Dversion="$version" -DimageRepoBase=eu.gcr.io/gitpod-core-dev/build .:docker --save "$bldfn"
 dev_image="$(tar xfO "$bldfn" ./imgnames.txt | head -n1)"
 echo "Dev Image: $dev_image"
 

dev/preview/workflow/preview/build.sh

@@ -67,6 +67,5 @@ leeway build \
     -DREPLICATED_API_TOKEN="$(kubectl --context=dev -n werft get secret replicated -o jsonpath='{.data.token}' | base64 -d)" \
     -DREPLICATED_APP="$(kubectl --context=dev -n werft get secret replicated -o jsonpath='{.data.app}' | base64 -d)" \
     -Dversion="${VERSION}" \
-    --dont-retag \
     --dont-test \
     dev/preview:deploy-dependencies