Skip to content

Conversation

codebytere
Copy link
Collaborator

@codebytere codebytere commented Oct 4, 2021

Supersedes #514.

Closes #510.

Adds a notification_referrer_id query parameter to the generated GitHub web urls for better user experience.

Before:

Screen Shot 2021-09-17 at 3 26 29 PM

After:

Screen Shot 2021-09-17 at 3 26 24 PM

TODO:

  • more tests maybe?
  • Enterprise accounts

@codebytere codebytere force-pushed the include_notification_referrer_id branch from a960842 to cfb7842 Compare October 4, 2021 10:13
@codebytere
Copy link
Collaborator Author

@manosim do you think this is ready to go?

@manosim
Copy link
Member

manosim commented Oct 28, 2021

Looks good! Been using it for the past couple of weeks without any issues. Let's merge it 🎉

@codebytere codebytere merged commit c3683dc into main Oct 28, 2021
@codebytere codebytere deleted the include_notification_referrer_id branch October 28, 2021 20:13
@setchy setchy added the enhancement New feature or enhancement to existing functionality label Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or enhancement to existing functionality

Development

Successfully merging this pull request may close these issues.

Include the notification_referrer_id for better UI

3 participants