Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Conversation

@grokys
Copy link
Contributor

@grokys grokys commented Jul 13, 2018

When "Open in Browser" is selected in the PR list, if the user has navigated multiple times to the PR list, then multiple tabs will be opened.

Ensure the PR list unsubscribes when it is unloaded.

@grokys grokys requested a review from jcansdale July 13, 2018 11:22
Copy link
Collaborator

@jcansdale jcansdale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed. Thanks for the quick fix! 🎉

@jcansdale jcansdale merged commit 1b6a9a1 into master Jul 13, 2018
@jcansdale jcansdale deleted the fixes/open-pr-in-browser branch July 13, 2018 14:01
@meaghanlewis meaghanlewis added this to the 2.5.4 milestone Jul 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants