Merge pull request #1781 from github/fixes/open-pr-in-browser

jcansdale · web-flow · commit 1b6a9a176b0c · 2018-07-13T15:01:14.000+01:00
Prevent opening PR in browser multiple times.
diff --git a/src/GitHub.VisualStudio/Views/GitHubPane/PullRequestListView.xaml.cs b/src/GitHub.VisualStudio/Views/GitHubPane/PullRequestListView.xaml.cs
@@ -27,6 +27,7 @@ public partial class PullRequestListView : UserControl
         public PullRequestListView()
         {
             InitializeComponent();
+
             DataContextChanged += (s, e) =>
             {
                 var vm = DataContext as IPullRequestListViewModel;
@@ -42,6 +43,12 @@ public PullRequestListView()
                         vm.OpenItemInBrowser.Subscribe(x => OpenInBrowser((IPullRequestListItemViewModel)x)));
                 }
             };
+
+            Unloaded += (s, e) =>
+            {
+                subscription?.Dispose();
+                subscription = null;
+            };
         }
 
         [Import]

Original file line number	Diff line number	Diff line change
`@@ -27,6 +27,7 @@ public partial class PullRequestListView : UserControl`
`27`	`27`	`public PullRequestListView()`
`28`	`28`	`{`
`29`	`29`	`InitializeComponent();`
	`30`	`+`
`30`	`31`	`DataContextChanged += (s, e) =>`
`31`	`32`	`{`
`32`	`33`	`var vm = DataContext as IPullRequestListViewModel;`
`@@ -42,6 +43,12 @@ public PullRequestListView()`
`42`	`43`	`vm.OpenItemInBrowser.Subscribe(x => OpenInBrowser((IPullRequestListItemViewModel)x)));`
`43`	`44`	`}`
`44`	`45`	`};`
	`46`	`+`
	`47`	`+ Unloaded += (s, e) =>`
	`48`	`+ {`
	`49`	`+ subscription?.Dispose();`
	`50`	`+ subscription = null;`
	`51`	`+ };`
`45`	`52`	`}`
`46`	`53`
`47`	`54`	`[Import]`