Heal 23 samsung galaxy z fold more info screen in landscape mode not able to scroll fully #854
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n on Android 10 IPC-756
…n ReviewView IPC-756
…iewBottomSheet IPC-756
…iewBottomSheet IPC-756
…ewFragment IPC-756
…-the-screen-while-rotation-on-Android-10 IPC 756 Keypad is not retaining on the screen while rotation on Android 10
… mode not able to scroll fully HEAL-23
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a scrolling issue on Samsung Galaxy Z Fold devices in landscape mode by replacing ScrollView with NestedScrollView and adding keyboard state restoration logic across orientation changes.
Key Changes:
- Replaced
ScrollViewwithNestedScrollViewin the landscape layout, using proper ConstraintLayout constraints - Added keyboard state tracking and restoration for Android Q and below
- Implemented a reusable
showKeyboard()extension function
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| gps_fragment_payment_more_information.xml | Replaced ScrollView with NestedScrollView and added ConstraintLayout positioning constraints |
| Extensions.kt | Added showKeyboard() extension function for View to handle keyboard display across Android versions |
| ReviewBottomSheet.kt | Implemented focus and keyboard state tracking/restoration with lifecycle-aware cleanup |
| ReviewFragment.kt | Added keyboard state restoration logic for pre-Android R devices with proper cleanup |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
health-sdk/sdk/src/main/java/net/gini/android/health/sdk/review/ReviewFragment.kt
Show resolved
Hide resolved
health-sdk/sdk/src/main/java/net/gini/android/health/sdk/review/ReviewFragment.kt
Outdated
Show resolved
Hide resolved
...rc/main/java/net/gini/android/internal/payment/review/reviewBottomSheet/ReviewBottomSheet.kt
Outdated
Show resolved
Hide resolved
obaidgini
reviewed
Oct 24, 2025
health-sdk/sdk/src/main/java/net/gini/android/health/sdk/review/ReviewFragment.kt
Outdated
Show resolved
Hide resolved
obaidgini
requested changes
Oct 24, 2025
Contributor
obaidgini
left a comment
obaidgini
left a comment
There was a problem hiding this comment.
Hi @MozhganPeivandianSharbaf
Overall PR looks good 👌
There are small comments from my side, and I believe co-pilot comments are also valid, can you please take a look and resolve these? Thank you.
…lay duration in ReviewFragment HEAL-23
…ReviewFragment HEAL-23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.