IPC 756 Keypad is not retaining on the screen while rotation on Android 10 #828
Conversation
…n on Android 10 IPC-756
…n ReviewView IPC-756
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where the virtual keyboard was not being retained on screen during device rotation on Android 10 and below. The solution implements keyboard state persistence and restoration specifically for API levels Q (29) and below.
Key changes:
- Added a keyboard visibility extension function for consistent IME management across API versions
- Implemented keyboard state tracking and restoration logic in ReviewBottomSheet for Android 10 and below
- Applied similar keyboard persistence functionality to ReviewFragment for consistent behavior
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| Extensions.kt | Adds a new showKeyboard() extension function that handles IME display with API version compatibility |
| ReviewBottomSheet.kt | Implements keyboard state persistence and restoration logic for Android 10 and below devices |
| ReviewFragment.kt | Applies similar keyboard persistence functionality to maintain consistency across fragments |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
...rc/main/java/net/gini/android/internal/payment/review/reviewBottomSheet/ReviewBottomSheet.kt
Outdated
Show resolved
Hide resolved
health-sdk/sdk/src/main/java/net/gini/android/health/sdk/review/ReviewFragment.kt
Show resolved
Hide resolved
...rc/main/java/net/gini/android/internal/payment/review/reviewBottomSheet/ReviewBottomSheet.kt
Show resolved
Hide resolved
…iewBottomSheet IPC-756
…iewBottomSheet IPC-756
MozhganPeivandianSharbaf
changed the base branch from
main
to
IPC-716-refactor-for-accessibility
| if (et?.isShown == true && et.isEnabled && et.isFocusable) { | ||
| viewLifecycleOwner.lifecycleScope.launch { | ||
| delay(VIEW_SETTLE_DELAY_MS) | ||
| et.showKeyboard() // your helper already requests focus |
There was a problem hiding this comment.
Can you please change it to
Helper already requests focus (removing your)
obaidgini
left a comment
obaidgini
left a comment
There was a problem hiding this comment.
@MozhganPeivandianSharbaf there is a small comment related to "comments". I have approved it because it is a very small change, when you get free please remove that. Thank you
…ewFragment IPC-756
MozhganPeivandianSharbaf
force-pushed
the
IPC-756--Keypad-is-not-retaining-on-the-screen-while-rotation-on-Android-10
branch
from
e8bd1d1 to
02a9751
Compare
|
MozhganPeivandianSharbaf
merged commit f4af3fc
into
IPC-716-refactor-for-accessibility
MozhganPeivandianSharbaf
deleted the
IPC-756--Keypad-is-not-retaining-on-the-screen-while-rotation-on-Android-10
branch
…n on Android 10
IPC-756