Skip to content

fix(insights): Make mobile app start queries compatible with React Native #87830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2025
Merged

fix(insights): Make mobile app start queries compatible with React Native #87830

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion static/app/views/insights/mobile/appStarts/components/charts/countChart.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ export function CountChart({chartHeight}: Props) {
query,
primaryRelease,
secondaryRelease
)} span.description:["Cold Start","Warm Start"]`;
)} span.description:["Cold Start","Warm Start","Cold App Start","Warm App Start"]`;

const {data: series, isPending: isSeriesLoading} = useEventsStatsQuery({
eventView: EventView.fromNewQueryWithPageFilters(
Expand Down
26 changes: 6 additions & 20 deletions static/app/views/insights/mobile/appStarts/components/eventSamples.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ import {
} from 'sentry/views/insights/common/components/releaseSelector';
import {useReleaseSelection} from 'sentry/views/insights/common/queries/useReleases';
import {COLD_START_TYPE} from 'sentry/views/insights/mobile/appStarts/components/startTypeSelector';
import useCrossPlatformProject from 'sentry/views/insights/mobile/common/queries/useCrossPlatformProject';
import {EventSamplesTable} from 'sentry/views/insights/mobile/screenload/components/tables/eventSamplesTable';
import {useTableQuery} from 'sentry/views/insights/mobile/screenload/components/tables/screensTable';
import {SpanMetricsField} from 'sentry/views/insights/types';
Expand Down Expand Up @@ -46,35 +45,22 @@ export function EventSamples({
const {primaryRelease} = useReleaseSelection();
const cursor = decodeScalar(location.query?.[cursorName]);

const {isProjectCrossPlatform, selectedPlatform} = useCrossPlatformProject();

const deviceClass = decodeScalar(location.query[SpanMetricsField.DEVICE_CLASS]) ?? '';
const startType =
decodeScalar(location.query[SpanMetricsField.APP_START_TYPE]) ?? COLD_START_TYPE;

const searchQuery = new MutableSearch([
`transaction:${transaction}`,
`release:${release}`,
startType
Copy link
Member Author

@markushi markushi Mar 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replaced this in favor of SpanMetricsField.APP_START_TYPE, as otherwise no data would be shown

? `${SpanMetricsField.SPAN_OP}:${
startType === COLD_START_TYPE ? 'app.start.cold' : 'app.start.warm'
}`
: 'span.op:[app.start.cold,app.start.warm]',
'(',
'span.description:"Cold Start"',
'OR',
'span.description:"Warm Start"',
')',
...(startType ? [`${SpanMetricsField.APP_START_TYPE}:${startType}`] : []),
...(deviceClass ? [`${SpanMetricsField.DEVICE_CLASS}:${deviceClass}`] : []),
// TODO: Add this back in once we have the ability to filter by start type
// `${SpanMetricsField.APP_START_TYPE}:${
// startType || `[${COLD_START_TYPE},${WARM_START_TYPE}]`
// }`,
]);

if (isProjectCrossPlatform) {
searchQuery.addFilterValue('os.name', selectedPlatform);
}
// TODO: Add this back in once os.name is available in the spansIndexed dataset
Copy link
Member Author

@markushi markushi Mar 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented this out for now, as it caused empty results as well. Seems like os.name is either null or and empty string right now.

// const {isProjectCrossPlatform, selectedPlatform} = useCrossPlatformProject();
// if (isProjectCrossPlatform) {
// searchQuery.addFilterValue('os.name', selectedPlatform);
// }

const sort = decodeSorts(location.query[sortKey])[0] ?? DEFAULT_SORT;

Expand Down
2 changes: 2 additions & 0 deletions static/app/views/insights/mobile/appStarts/components/spanOpSelector.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,8 @@ export function SpanOpSelector({transaction, primaryRelease, secondaryRelease}:
// Exclude root level spans because they're comprised of nested operations
'!span.description:"Cold Start"',
'!span.description:"Warm Start"',
'!span.description:"Cold App Start"',
'!span.description:"Warm App Start"',
// Exclude this span because we can get TTID contributing spans instead
'!span.description:"Initial Frame Render"',
'has:span.description',
Expand Down
10 changes: 8 additions & 2 deletions static/app/views/insights/mobile/appStarts/components/startDurationWidget.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,14 @@ import {COLD_START_TYPE} from 'sentry/views/insights/mobile/appStarts/components
import useCrossPlatformProject from 'sentry/views/insights/mobile/common/queries/useCrossPlatformProject';
import {SpanMetricsField} from 'sentry/views/insights/types';

const COLD_START_CONDITIONS = ['span.op:app.start.cold', 'span.description:"Cold Start"'];
const WARM_START_CONDITIONS = ['span.op:app.start.warm', 'span.description:"Warm Start"'];
const COLD_START_CONDITIONS = [
'span.op:app.start.cold',
'span.description:["Cold Start","Cold App Start"]',
];
const WARM_START_CONDITIONS = [
'span.op:app.start.warm',
'span.description:["Warm Start","Warm App Start"]',
];

export function transformData(data?: MultiSeriesEventsStats, primaryRelease?: string) {
const transformedSeries: {[releaseName: string]: Series} = {};
Expand Down
2 changes: 2 additions & 0 deletions static/app/views/insights/mobile/appStarts/components/systemApplicationBreakdown.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,8 @@ function SystemApplicationBreakdown({additionalFilters}: any) {
'span.op:[app.start.warm,app.start.cold,contentprovider.load,application.load,activity.load]',
'!span.description:"Cold Start"',
'!span.description:"Warm Start"',
'!span.description:"Cold App Start"',
'!span.description:"Warm App Start"',
...(additionalFilters ?? []),
]);

Expand Down
2 changes: 2 additions & 0 deletions static/app/views/insights/mobile/appStarts/components/tables/spanOperationTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,8 @@ export function SpanOperationTable({
// Exclude root level spans because they're comprised of nested operations
'!span.description:"Cold Start"',
'!span.description:"Warm Start"',
'!span.description:"Cold App Start"',
'!span.description:"Warm App Start"',
// Exclude this span because we can get TTID contributing spans instead
'!span.description:"Initial Frame Render"',
'has:span.description',
Expand Down
4 changes: 2 additions & 2 deletions static/app/views/insights/mobile/appStarts/views/screenSummaryPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,9 +149,9 @@ export function ScreenSummaryContentPage() {
`transaction:${transactionName}`,
`span.op:app.start.${appStartType}`,
'(',
'span.description:"Cold Start"',
'span.description:["Cold Start","Cold App Start"]',
'OR',
'span.description:"Warm Start"',
'span.description:["Warm Start","Warm App Start"]',
')',
]}
fields={[
Expand Down
Loading