fix(insights): Make mobile app start queries compatible with React Native #87830
Conversation
github-actions
bot
added
the
Scope: Frontend
| const searchQuery = new MutableSearch([ | ||
| `transaction:${transaction}`, | ||
| `release:${release}`, | ||
| startType |
There was a problem hiding this comment.
Replaced this in favor of SpanMetricsField.APP_START_TYPE, as otherwise no data would be shown
| if (isProjectCrossPlatform) { | ||
| searchQuery.addFilterValue('os.name', selectedPlatform); | ||
| } | ||
| // TODO: Add this back in once os.name is available in the spansIndexed dataset |
There was a problem hiding this comment.
Commented this out for now, as it caused empty results as well. Seems like os.name is either null or and empty string right now.
There was a problem hiding this comment.
The code seems fine to me, but I don't have any domain knowledge here. I trust you! cc @narsaynorath in case he has questions/concerns.
There was a problem hiding this comment.
Changes to the app start filters make sense to me! The os.name filter is odd but I can try to find out why os.name isn't working. We seem to tag it in the span data and I thought we collected it before, so I'm not entirely sure why it's not filtering. I won't be able to take a look until Thursday/Friday at the moment though
markushi
deleted the
markushi/fix/mobile-insights-missing-cold-warm-start-data-rn
branch
…tive (#87830) Fixes #86707 ### Legal Boilerplate Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Fixes #86707
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.