Skip to content

chore: bump Sentry SDK to v9 alpha #84258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Feb 3, 2025
Merged

chore: bump Sentry SDK to v9 alpha #84258

merged 7 commits into from
Feb 3, 2025

Conversation

c298lee
Copy link
Contributor

@c298lee c298lee commented Jan 29, 2025 •
edited
Loading

@c298lee c298lee requested review from a team as code owners January 29, 2025 20:09
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jan 29, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 29, 2025 •
edited
Loading

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
4126 1 4125 0
View the top 1 failed tests by shortest run time 
Docs Search Modal can open help search modal
Stack Traces | 0.087s run time 
TypeError: hoistNonReactStatics.default is not a function
    at withProfiler (.../sentry/sentry/node_modules/@.../react/src/profiler.tsx:173:23)
    at Object.<anonymous> (.../app/components/loadingIndicator.tsx:54:58)
    at Runtime._execModule (.../sentry/sentry/node_modules/jest-runtime/build/index.js:1439:24)
    at Runtime._loadModule (.../sentry/sentry/node_modules/jest-runtime/build/index.js:1022:12)
    at Runtime.requireModule (.../sentry/sentry/node_modules/jest-runtime/build/index.js:882:12)
    at Runtime.requireModuleOrMock (.../sentry/sentry/node_modules/jest-runtime/build/index.js:1048:21)
    at Object.<anonymous> (.../forms/controls/selectControl.tsx:17:48)
    at Runtime._execModule (.../sentry/sentry/node_modules/jest-runtime/build/index.js:1439:24)
    at Runtime._loadModule (.../sentry/sentry/node_modules/jest-runtime/build/index.js:1022:12)
    at Runtime.requireModule (.../sentry/sentry/node_modules/jest-runtime/build/index.js:882:12)
    at Runtime.requireModuleOrMock (.../sentry/sentry/node_modules/jest-runtime/build/index.js:1048:21)
    at Object.<anonymous> (.../app/components/contextPickerModal.tsx:11:45)
    at Runtime._execModule (.../sentry/sentry/node_modules/jest-runtime/build/index.js:1439:24)
    at Runtime._loadModule (.../sentry/sentry/node_modules/jest-runtime/build/index.js:1022:12)
    at Runtime.requireModule (.../sentry/sentry/node_modules/jest-runtime/build/index.js:882:12)
    at Runtime.requireModuleOrMock (.../sentry/sentry/node_modules/jest-runtime/build/index.js:1048:21)
    at Object.<anonymous> (.../app/actionCreators/navigation.tsx:9:50)
    at Runtime._execModule (.../sentry/sentry/node_modules/jest-runtime/build/index.js:1439:24)
    at Runtime._loadModule (.../sentry/sentry/node_modules/jest-runtime/build/index.js:1022:12)
    at Runtime.requireModule (.../sentry/sentry/node_modules/jest-runtime/build/index.js:882:12)
    at Runtime.requireModuleOrMock (.../sentry/sentry/node_modules/jest-runtime/build/index.js:1048:21)
    at Object.<anonymous> (.../components/search/index.tsx:12:19)
    at Runtime._execModule (.../sentry/sentry/node_modules/jest-runtime/build/index.js:1439:24)
    at Runtime._loadModule (.../sentry/sentry/node_modules/jest-runtime/build/index.js:1022:12)
    at Runtime.requireModule (.../sentry/sentry/node_modules/jest-runtime/build/index.js:882:12)
    at Runtime.requireModuleOrMock (.../sentry/sentry/node_modules/jest-runtime/build/index.js:1048:21)
    at Object.<anonymous> (.../app/components/helpSearch.tsx:10:15)
    at Runtime._execModule (.../sentry/sentry/node_modules/jest-runtime/build/index.js:1439:24)
    at Runtime._loadModule (.../sentry/sentry/node_modules/jest-runtime/build/index.js:1022:12)
    at Runtime.requireModule (.../sentry/sentry/node_modules/jest-runtime/build/index.js:882:12)
    at Runtime.requireModuleOrMock (.../sentry/sentry/node_modules/jest-runtime/build/index.js:1048:21)
    at Object.<anonymous> (.../components/modals/helpSearchModal.tsx:10:42)
    at Runtime._execModule (.../sentry/sentry/node_modules/jest-runtime/build/index.js:1439:24)
    at Runtime._loadModule (.../sentry/sentry/node_modules/jest-runtime/build/index.js:1022:12)
    at Runtime.requireModule (.../sentry/sentry/node_modules/jest-runtime/build/index.js:882:12)
    at Runtime.requireModuleOrMock (.../sentry/sentry/node_modules/jest-runtime/build/index.js:1048:21)
    at .../app/actionCreators/modal.tsx:158:74
    at processTicksAndRejections (node:internal/process/task_queues:105:5)
    at openHelpSearchModal (.../app/actionCreators/modal.tsx:158:15)

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@c298lee c298lee requested a review from a team as a code owner January 30, 2025 00:20
billyvg
billyvg approved these changes Jan 30, 2025
View reviewed changes
Copy link
Member

@billyvg billyvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move the annotations to a separate PR, otherwise LGTM

static/app/components/feedback/widget/useFeedback.tsx Outdated
@@ -31,6 +31,7 @@ export function useFeedback({
messagePlaceholder: messagePlaceholder ?? t('What did you expect?'),
formTitle: formTitle ?? t('Give Feedback'),
tags,
_experiments: {annotations: true},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make a new PR for this -- also, is this something we want to feature flag?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point! i'll add a ff for this

@billyvg
Copy link
Member

billyvg commented Jan 30, 2025

@c298lee oh forgot to mention, did you check getsentry as well?

@chargome chargome mentioned this pull request Jan 30, 2025
Merged
@c298lee c298lee changed the title chore: bump Sentry SDK to 9.0.0-alpha.0 chore: bump Sentry SDK to v9 alpha Feb 3, 2025
@c298lee c298lee merged commit 987dcd0 into master Feb 3, 2025
42 checks passed
@c298lee c298lee deleted the cl/bump-to-v9 branch February 3, 2025 19:25
@billyvg billyvg mentioned this pull request Feb 3, 2025
Closed
@Zylphrex Zylphrex mentioned this pull request Feb 4, 2025
Merged
Zylphrex added a commit that referenced this pull request Feb 4, 2025
@Zylphrex
chore(sdk): Revert sentry sdk v9.0.0-alpha.1 (#84527)
530c346 
Not sure what the problem is but this upgrade is causing webpack to not
proxy `/api/client-config` correctly.

Originally introduced in #84258
@ryan953 ryan953 mentioned this pull request Feb 5, 2025
Merged
andrewshie-sentry pushed a commit that referenced this pull request Feb 5, 2025
@c298lee @andrewshie-sentry
chore: bump Sentry SDK to v9 alpha (#84258)
d0da58c 
Related PRs for updating some deprecations:
- #84130
- #84132
- #84196
- #84254

PR for updating getsentry:
getsentry/getsentry#16292
andrewshie-sentry pushed a commit that referenced this pull request Feb 5, 2025
@Zylphrex @andrewshie-sentry
chore(sdk): Revert sentry sdk v9.0.0-alpha.1 (#84527)
a428f1e 
Not sure what the problem is but this upgrade is causing webpack to not
proxy `/api/client-config` correctly.

Originally introduced in #84258
@github-actions github-actions bot locked and limited conversation to collaborators Feb 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@billyvg billyvg billyvg approved these changes

Assignees
No one assigned
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@c298lee @billyvg